Restore the IndexError in pygpu_index.#452
Merged
nouiz merged 1 commit intoTheano:masterfrom Jun 9, 2017
Merged
Conversation
nouiz
requested changes
Jun 9, 2017
| array_index(res, a, starts, stops, steps) | ||
| try: | ||
| array_index(res, a, starts, stops, steps) | ||
| except ValueError, e: |
Member
There was a problem hiding this comment.
Why this is needed? Can you add a test to make sure this don't get broken again?
Member
|
As this is a regression fix, I'll merge now. But adding the test after would be great. |
Member
|
And probably changing the error at the C level to be of the right type. |
Member
|
Should we run Theano gpu tests once to make sure to not break it again? |
Member
|
Ideally, I think we should include the tests in |
Member
Author
|
Instead of having the Theano PRs depend on the master of libgpuarray, we should depend on a tag and/or the latest release. This way a nightly buildbot or some such catch these issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix regression reported in https://github.com/Theano/libgpuarray/pull/449/files/e2f1f07accad1561db8177d85f119dfd3bcdfa2a#diff-ff48e8755d3dfca5cabbf877f62ff560