Skip to content

Restore the IndexError in pygpu_index. #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nouiz merged 1 commit into from
Jun 9, 2017
Merged

Restore the IndexError in pygpu_index. #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pygpu/gpuarray.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,7 +1412,10 @@ cdef GpuArray pygpu_index(GpuArray a, const ssize_t *starts,
const ssize_t *stops, const ssize_t *steps):
cdef GpuArray res
res = new_GpuArray(type(a), a.context, a.base)
array_index(res, a, starts, stops, steps)
try:
array_index(res, a, starts, stops, steps)
except ValueError, e:
Copy link
Copy Markdown
Member

@nouiz nouiz Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is needed? Can you add a test to make sure this don't get broken again?

raise IndexError, "index out of bounds"
return res

cdef GpuArray pygpu_reshape(GpuArray a, unsigned int nd, const size_t *newdims,
Expand Down