Skip to content

Add Secure configuration option for MinIO client#1

Closed
DanPlayz0 wants to merge 0 commit intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/support-insecure-s3
Closed

Add Secure configuration option for MinIO client#1
DanPlayz0 wants to merge 0 commit intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/support-insecure-s3

Conversation

@DanPlayz0
Copy link
Copy Markdown
Contributor

@DanPlayz0 DanPlayz0 commented Mar 4, 2025

This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.

This pull request includes several changes to improve the configuration and initialization of the MinIO client across various files. The most significant changes involve the addition of the Secure configuration option and the reorganization of import statements.

Configuration improvements:

  • pkg/config/cliconfig.go: Added a Secure field to the CliConfig struct with a default value of true to allow configuration of secure connections to the S3 service.
  • pkg/config/config.go: Added a Secure field to the Config struct with a default value of true to allow configuration of secure connections to the S3 service.

MinIO client initialization:

  • cmd/cleanuser/main.go, cmd/deletetranscript/main.go, cmd/exportguild/main.go, pkg/s3client/clientmanager.go: Updated the MinIO client initialization to use the Secure configuration option instead of hardcoding the value to true. [1] [2] [3] [4]

Import statement reorganization:

  • cmd/cleanuser/main.go, cmd/deletetranscript/main.go, cmd/exportguild/main.go, pkg/s3client/clientmanager.go: Reorganized import statements for better readability and consistency. [1] [2] [3] [4]

More Pull Requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant