Add Secure configuration option for MinIO client#1
Closed
DanPlayz0 wants to merge 0 commit intoTicketsBot-cloud:masterfrom
Closed
Add Secure configuration option for MinIO client#1DanPlayz0 wants to merge 0 commit intoTicketsBot-cloud:masterfrom
DanPlayz0 wants to merge 0 commit intoTicketsBot-cloud:masterfrom
Conversation
This was referenced Mar 9, 2025
ffd5980 to
d514107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.
This pull request includes several changes to improve the configuration and initialization of the MinIO client across various files. The most significant changes involve the addition of the
Secureconfiguration option and the reorganization of import statements.Configuration improvements:
pkg/config/cliconfig.go: Added aSecurefield to theCliConfigstruct with a default value oftrueto allow configuration of secure connections to the S3 service.pkg/config/config.go: Added aSecurefield to theConfigstruct with a default value oftrueto allow configuration of secure connections to the S3 service.MinIO client initialization:
cmd/cleanuser/main.go,cmd/deletetranscript/main.go,cmd/exportguild/main.go,pkg/s3client/clientmanager.go: Updated the MinIO client initialization to use theSecureconfiguration option instead of hardcoding the value totrue. [1] [2] [3] [4]Import statement reorganization:
cmd/cleanuser/main.go,cmd/deletetranscript/main.go,cmd/exportguild/main.go,pkg/s3client/clientmanager.go: Reorganized import statements for better readability and consistency. [1] [2] [3] [4]More Pull Requests