Add secure connection option for S3#2
Closed
DanPlayz0 wants to merge 1 commit intoTicketsBot-cloud:mainfrom
Closed
Add secure connection option for S3#2DanPlayz0 wants to merge 1 commit intoTicketsBot-cloud:mainfrom
DanPlayz0 wants to merge 1 commit intoTicketsBot-cloud:mainfrom
Conversation
|
I made this change previously, and it gets past the initial error, but still tries to force My archive S3 endpoint is |
Contributor
Author
|
@Substrata1 Did you also update log archiver to support |
This was referenced Mar 9, 2025
Contributor
Author
|
PR is being re-created as merge conflicts are not that simple this time around. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.
This pull request includes changes to enhance the configuration and initialization of the S3 client by adding a new configuration option for secure connections.
Configuration enhancement:
internal/config/config.go: Added a newSecureboolean field to theConfigstruct to allow configuration of secure connections to the S3 service. This field is set totrueby default.Initialization update:
cmd/import/main.go: Updated the initialization of the S3 client to use the newSecureconfiguration option instead of a hardcodedtruevalue.More Pull Requests