Skip to content

Add secure connection option for S3#10

Merged
BenHall-1 merged 1 commit intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/support-insecure-s3
May 14, 2025
Merged

Add secure connection option for S3#10
BenHall-1 merged 1 commit intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/support-insecure-s3

Conversation

@DanPlayz0
Copy link
Copy Markdown
Contributor

@DanPlayz0 DanPlayz0 commented Mar 4, 2025

This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.

This pull request introduces changes to add a Secure configuration option for S3 connections. The most important changes include modifying the S3 connection function to accept a secure parameter, updating the configuration struct to include this new parameter, and adjusting the main function to pass the secure parameter when connecting to S3.

Changes to S3 connection:

  • s3/s3.go: Modified the ConnectS3 function to accept a secure parameter and use it in the Minio client initialization.

Configuration updates:

  • config/config.go: Added a Secure field to the S3Import struct in the configuration, with a default value of true.

Main function adjustments:

  • cmd/api/main.go: Updated the S3 connection call in the main function to include the new secure parameter from the configuration.

More Pull Requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants