Add secure connection option for S3#10
Merged
BenHall-1 merged 1 commit intoTicketsBot-cloud:masterfrom May 14, 2025
Merged
Conversation
This was referenced Mar 9, 2025
BenHall-1
approved these changes
May 14, 2025
This was referenced May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.
This pull request introduces changes to add a
Secureconfiguration option for S3 connections. The most important changes include modifying the S3 connection function to accept asecureparameter, updating the configuration struct to include this new parameter, and adjusting the main function to pass thesecureparameter when connecting to S3.Changes to S3 connection:
s3/s3.go: Modified theConnectS3function to accept asecureparameter and use it in the Minio client initialization.Configuration updates:
config/config.go: Added aSecurefield to theS3Importstruct in the configuration, with a default value oftrue.Main function adjustments:
cmd/api/main.go: Updated the S3 connection call in themainfunction to include the newsecureparameter from the configuration.More Pull Requests