Add Secure configuration option for MinIO client#2
Merged
BenHall-1 merged 1 commit intoTicketsBot-cloud:masterfrom May 15, 2025
Merged
Conversation
This was referenced May 15, 2025
BenHall-1
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.
This pull request introduces a configurable
Secureoption for MinIO clients, replacing the hardcodedtruevalue with a dynamic configuration. This change allows theSecuresetting to be toggled based on environment variables or configuration files, enhancing flexibility and adaptability across different environments.MinIO Client Configuration Updates:
Secure: truewith a dynamicSecurevalue derived from configuration objects in multiple files (cmd/cleanuser/main.go,cmd/deletetranscript/main.go,cmd/exportguild/main.go,cmd/exportuser/main.go,cmd/fix-file-names/main.go, andpkg/s3client/clientmanager.go). This enables theSecureflag to be configured per environment. [1] [2] [3] [4] [5] [6]Configuration Struct Enhancements:
Securefield to theCliConfigstruct inpkg/config/cliconfig.go, with an environment variableS3_SECUREand a default value oftrue.Securefield to theConfigstruct inpkg/config/config.go, with an environment variableS3_SECUREand a default value oftrue.More Pull Requests