Skip to content

Add Secure configuration option for MinIO client#2

Merged
BenHall-1 merged 1 commit intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/support-insecure-s3
May 15, 2025
Merged

Add Secure configuration option for MinIO client#2
BenHall-1 merged 1 commit intoTicketsBot-cloud:masterfrom
DanPlayz0:feat/support-insecure-s3

Conversation

@DanPlayz0
Copy link
Copy Markdown
Contributor

@DanPlayz0 DanPlayz0 commented May 15, 2025

This PR adds a feature for users who do not want to deal with TLS with S3. This is mostly a feature for self-hosted instances of the bot.

This pull request introduces a configurable Secure option for MinIO clients, replacing the hardcoded true value with a dynamic configuration. This change allows the Secure setting to be toggled based on environment variables or configuration files, enhancing flexibility and adaptability across different environments.

MinIO Client Configuration Updates:

  • Replaced the hardcoded Secure: true with a dynamic Secure value derived from configuration objects in multiple files (cmd/cleanuser/main.go, cmd/deletetranscript/main.go, cmd/exportguild/main.go, cmd/exportuser/main.go, cmd/fix-file-names/main.go, and pkg/s3client/clientmanager.go). This enables the Secure flag to be configured per environment. [1] [2] [3] [4] [5] [6]

Configuration Struct Enhancements:

  • Added a Secure field to the CliConfig struct in pkg/config/cliconfig.go, with an environment variable S3_SECURE and a default value of true.
  • Added a Secure field to the Config struct in pkg/config/config.go, with an environment variable S3_SECURE and a default value of true.

More Pull Requests

@BenHall-1 BenHall-1 merged commit 7298e06 into TicketsBot-cloud:master May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants