Support for returning multi-dimensional R arrays#263
Merged
eddelbuettel merged 4 commits intomasterfrom Jun 22, 2021
Merged
Conversation
|
This pull request has been linked to Clubhouse Story #8255: Support as.array return object. |
ihnorton
approved these changes
Jun 22, 2021
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
Tested a bit with 3x3 array from Python, LGTM from my perspective.
Contributor
Author
|
Thanks, and yes: it was a well-motivated use case, and with it now in the main branch, and likely a new release soon to deploy TileDB 2.3.1, we can go back to user who filed this in #259. |
eddelbuettel
added a commit
that referenced
this pull request
Jun 23, 2021
eddelbuettel
added a commit
that referenced
this pull request
Jun 23, 2021
* updated configure and downloader scripts for arm64 * standard behavior without override for header detection * more careful use of optional second argument * call fetchTileDB.sh with arguments os and machine (ie arch) * make use of architecture argument * updated for for 2.3.1, plus filename pattern change * update NEWS file for #263 and #264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on the correction in PR #260 for the issue raised in #259 and extends support for multidimensional array returns, which is most applicable for dense arrayss with their implicit indices along the individual dimensions. It adds a logical slot to the
tiledb_arrayobject, similar to the choices formatrixordata.framereturn, ensures at most one of those choices is selected, adds some getters and setters, as well as a conversion function.