Prepare for linking with UCRT binaries

[jeroen]

Minimal tweak that will allow you to add the ucrt binaries in rwinlib-tiledb under lib/x64-ucrt. The trick here is that R-for-ucrt builds use Makevars.ucrt to build if it exists.

This is the same pattern we use for many other packages, eg https://github.com/jeroen/curl/blob/master/src/Makevars.ucrt with https://github.com/rwinlib/libcurl/tree/master/lib

[eddelbuettel]

Thanks @jeroen -- can confirm that the pattern suggested here appears to work fine as e.g. seen on the RcppRedis package for which you had already sent a PR -- but note that it currently nags you about an included binary.

[jeroen]

but note that it currently nags you about an included binary.

Maybe try adding windows to the rbuildignore, as you already do here:

TileDB-R/.Rbuildignore

Line 20 in 939ce3b

^windows

[eddelbuettel]

Nice catch, thanks. Will all packages relying on your tools/winlibs.R usage pattern need that?

[jeroen]

Nice catch, thanks. Will all packages relying on your tools/winlibs.R usage pattern need that?

No, it's just a temporary glitch because Tomas extracts, patches and then rebuilds the source package on the ucrt server. The note will probably also disappear by itself once he removes the server patches.

[eddelbuettel]

The PR is fine, and truly appreciated.

We contemplated leaving it open until we have a proper artifact (as our UCRT build TileDB Embedded is still in a branch) but as the Makefile.ucrt will only used by a suitable builder there will not be any side-effects.