Update TileDB Embedded to release 2.3.2

[eddelbuettel]

No description provided.

[shortcut-integration]

This pull request has been linked to Clubhouse Story #8893: Upgrade to TileDB Embedded 2.3.2.

[jeroen]

You forgot to add the new ucrt binaries to https://github.com/TileDB-Inc/rwinlib-tiledb/releases/tag/v2.3.2 as needed by #268

You can take the dependencies from https://cran.r-project.org/bin/windows/Rtools/4.0/ucrt64/

[eddelbuettel]

@jeroen: I actually didn't "forget". I downloaded all three of our artificacts (which are now ready for x86 (32 bit), x86_64 (64 bit) ad x86_64-ucrt (64 bit too) but the amalgamating rwinlib repo (which is of course a fork off yours) does not have all the required libraries yet. PRs would be welcome, especially as I cannot test 'ucrt' builds. Otherwise this will wait until I am no longer on vacation 🌴 which should still be plenty time before we upload to CRAN which is the only place using this. But big thank you for paying attention and the links, it will come in handy.

[eddelbuettel]

Now done in two commits for all non-TileDB libraries taken from CRAN and the TileDB library (using the same GH Actions run from the 2.3.2).

So this should be ready once we roll up TileDB 2.3.3. Is there a chance to test this outside of a CRAN upload?

[jeroen]

You can test it on a windows machine using these instructions. I can also do it for you, but you need to move the v2.3.2 tag in your rwinlib repo (which your R package downloads from) to the latest commit, which includes the ucrt libs.

Easiest is to just delete both v2.3.2 "release" and tag via the Github webui, and then re-creating the release.

[eddelbuettel]

It's a nice idea to keep the tag yet roll the commit forward to a strict super-set commit but as this is a TileDB repo I would rather not do that as we generally prefer not to touch releases once made. Even if this is a fork.

[jeroen]

OK then you will need to create a new tag. Your R package currently downloads the libs from: https://github.com/TileDB-Inc/rwinlib-tiledb/tree/v2.3.2 which does not include ucrt binaries.

[eddelbuettel]

I am aware that the CRAN package 0.9.2 does not create ucrt binaries. The plan is to use the extended rwinlib repo, with the build script already in place, for release 0.9.3 likely based on TileDB Embedded 2.3.3. It is not all that urgent. A test would be nice, but if it involves too much moving of deck chairs we won't have the test.

[jeroen]

I was not talking about the CRAN version, but the master brach as of the above PR.

Well I was able to manually confirm that if I temporary set your tiledbVersion.txt to use master such that it downloads the latest version of the rwinlib tiledb stack, then the build succeeds on ucrt.

[eddelbuettel]

(Small nit: The CRAN version of the R package is pinned to this tag 2.3.2 which is why we prefer not to touch the tag. Next release of TileDB Embedded with get a new tag in rwinlib, and the next CRAN package will use that to-be-created tag.)

Nice hack using master -- and thanks so much for testing! I really appreciate it, and I wish we had an ucrt winbuilder (or rhub instance). Alas, we don't. So thanks again,

[jeroen]

Afaict, the CRAN version was released a month ago and is pinned to 2.3.1, whereas the 2.3.2 tag was only created a week ago.

[eddelbuettel]

Yes, sorry, the CRAN package is 0.9.4 which uses 2.3.1.

Release 2.3.2 was prepared, and tagged after its release and before UCRT was in. Our preference is still to treat tags as immutable.

A future release 2.3.3 will be ready for UCRT, and a CRAN release 0.9.5 will use it.