Set minimum TileDB version to 2.0.0#313
Merged
eddelbuettel merged 5 commits intomasterfrom Oct 27, 2021
Merged
Conversation
|
This pull request has been linked to Shortcut Story #11521: Move minimum TileDB Embedded version to (at least) 2.0.0. |
Shelnutt2
approved these changes
Oct 27, 2021
Contributor
Shelnutt2
left a comment
Shelnutt2
left a comment
There was a problem hiding this comment.
+1 for drawing the line at TileDB 2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code for the R package still accomodates older versions. This (eventually) needs some rationalizations. This PR suggests to draw the current line TileDB 2.0.0, released well over a year ago. It removes some conditional compilation in the C++ code, and relaxes / removes some version tests in the unit testing setup. Going forward, we can do similar updates quarterly or as needed.