Merged
Conversation
|
This pull request has been linked to Shortcut Story #12830: Export helper type mapping function used by BioConductor's TileDBArray. |
aaronwolen
approved these changes
Dec 13, 2021
ihnorton
approved these changes
Dec 13, 2021
Member
ihnorton
left a comment
There was a problem hiding this comment.
I believe the mapping here is stable and (effectively) covered by existing tests, since we use this function internally, right?
Contributor
Author
|
Yes it should be and the package itself does not use it outside of code disappearing with the to-be-deprecated-in-draft-PR-#335: edd@rob:~/git/tiledb-r(feature/sc-12830/export_datatype_mapper)$ ag tiledb_datatype_R_type R/
R/SparseArray.R
116: type <- tiledb_datatype_R_type(dtype)
R/DenseArray.R
231: type <- tiledb_datatype_R_type(dtype)
R/RcppExports.R
51:tiledb_datatype_R_type <- function(datatype) {
52: .Call(`_tiledb_tiledb_datatype_R_type`, datatype)
edd@rob:~/git/tiledb-r(feature/sc-12830/export_datatype_mapper)$ So it really is just a courtesy export for external functionality shadowing what we used to do / still do (technically) til the deprecated code is lifted. But it does no harm and is, as you say, type-stable. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of a micro-PR to benefit @LTLA and BioConductor package TileDBArray which currently accesses a C++-level function
tiledb_datatype_R_typemapping from TileDB type (as string) to R type (as string) via:::as the function is not exported.This PR corrects this and exports the function.