Add vignette on installation options#358
Merged
eddelbuettel merged 3 commits intomasterfrom Jan 26, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #8317: Document installation / deployment options. |
ihnorton
approved these changes
Jan 26, 2022
Member
ihnorton
left a comment
ihnorton
left a comment
There was a problem hiding this comment.
LGTM, minor suggestions to take-or-leave as you like.
eddelbuettel
force-pushed
the
de/sc-8317/document_installation_options
branch
from
7cc585c to
73096b0
Compare
eddelbuettel
force-pushed
the
de/sc-8317/document_installation_options
branch
from
73096b0 to
f939fa1
Compare
Contributor
Author
|
Rebased, which reduced this PR to the net two commits. Will let it CI once more and merge once done. |
Contributor
Author
|
I added two conditional statements in a unit test test file two not have two tests run with TileDB versions earlier than 2.3.0. (That came up in other tests and should be inconsequential here.) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple vignette describing different installation options available.
PR #357 is pre-requirement as this vignette uses the same engine
simplermarkdownwhich #357 adds to the package. So this PR currently includes PR #357 but a rebase after a merge of #357 would reduce it to just commit ff2221e.