Adjust filter tests by using explicit file-local VFS object#407
Merged
eddelbuettel merged 1 commit intomasterfrom May 10, 2022
Merged
Adjust filter tests by using explicit file-local VFS object#407eddelbuettel merged 1 commit intomasterfrom
eddelbuettel merged 1 commit intomasterfrom
Conversation
|
This pull request has been linked to Shortcut Story #17654: Refactor filter tests from PR 406. |
ihnorton
approved these changes
May 10, 2022
eddelbuettel
added a commit
that referenced
this pull request
May 13, 2022
eddelbuettel
added a commit
that referenced
this pull request
May 14, 2022
* pause a part of the filter test file for now * renamed check to schema_check, set deprecation message * remove temporary adjustment following #407 merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjust the new Filter tests from #406 by using a file-local VFS object. This appears to help against sporadic failures that are seen with the package-environment-global VFS (using the same mechanism we use for Ctx and Config objects).
No code changes outside this adjustment to one test file.