Deprecate 'check' and switch to 'schema_check'#409
Merged
eddelbuettel merged 3 commits intomasterfrom May 14, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #17634: Deprecate tiledb::check and add it as tiledb::check_schema. |
aaronwolen
approved these changes
May 13, 2022
Member
aaronwolen
left a comment
aaronwolen
left a comment
There was a problem hiding this comment.
Nice! Regardless of conflicts I like the new more expressive name.
ihnorton
approved these changes
May 14, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new generic and method
schema_check()and deprecates the existingcheck()which clashes with a function by thedevtoolspackage leading to a noisy startup message.No other code changes. One help file is updated as a followup to PR #407.