Skip to content

Add support for OR query condition operations#417

Merged
eddelbuettel merged 3 commits intomasterfrom
de/sc-17917/or_query
Jun 7, 2022
Merged

Add support for OR query condition operations#417
eddelbuettel merged 3 commits intomasterfrom
de/sc-17917/or_query

Conversation

@eddelbuettel
Copy link
Copy Markdown
Contributor

@eddelbuettel eddelbuettel commented May 24, 2022

This PR adds support for OR query condition operations via additional tests.

No code changes are needed, and documentation is updated.

Leaving this as a draft until OR support is merged. Now a proper PR.

@eddelbuettel eddelbuettel requested a review from ihnorton May 24, 2022 17:07
@shortcut-integration
Copy link
Copy Markdown

This pull request has been linked to Shortcut Story #17917: Add support for OR query conditions.

@eddelbuettel eddelbuettel force-pushed the de/sc-17917/or_query branch from 9539bbc to ee5a318 Compare June 7, 2022 17:14
@eddelbuettel eddelbuettel marked this pull request as ready for review June 7, 2022 17:54
@eddelbuettel eddelbuettel requested a review from aaronwolen June 7, 2022 17:54
Copy link
Copy Markdown
Member

@aaronwolen aaronwolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

Copy link
Copy Markdown
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM!

@eddelbuettel eddelbuettel merged commit 5072545 into master Jun 7, 2022
@eddelbuettel eddelbuettel deleted the de/sc-17917/or_query branch June 7, 2022 18:01
@eddelbuettel eddelbuettel mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants