Do not run filter compression tests on Linux without AVX2#418
Merged
eddelbuettel merged 1 commit intomasterfrom May 25, 2022
Merged
Do not run filter compression tests on Linux without AVX2#418eddelbuettel merged 1 commit intomasterfrom
eddelbuettel merged 1 commit intomasterfrom
Conversation
|
This pull request has been linked to Shortcut Story #18096: Protect new filter compression tests from ancient hardware. |
Contributor
Author
|
(Accidental 'draft pr' was a leftover from #417 set up as PR. This one is ready.) |
ihnorton
approved these changes
May 25, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exists out of filter tests before compression tests are run if two conditions are met: running on Linux, and not seeing AVX2 capabiltiies stated (in lowercase) in
/proc/cpuinfo. This avoids some tests failure observed on older hardware.No new code.