Add check for missing column in array write#483
Merged
eddelbuettel merged 1 commit intomasterfrom Nov 10, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #23320: Investigate write with subset of columns. |
awenocur
approved these changes
Nov 9, 2022
eddelbuettel
added a commit
that referenced
this pull request
Nov 18, 2022
eddelbuettel
added a commit
that referenced
this pull request
Nov 24, 2022
eddelbuettel
added a commit
that referenced
this pull request
Nov 28, 2022
eddelbuettel
added a commit
that referenced
this pull request
Nov 29, 2022
* Default sparse read via tiledb_array to UNORDERED * Use nchar(layout) not length, and wrap in isTRUE for comparison * Update NEWS.md for #483, #484, #485, and #487 * Update NEWS for #488 [ci skip] * Roll micro release to 0.16.0.3 [ci skip] * Add codecov.yml to .Rbuildignore * Tighten one version-based test exclusion
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the situation brought up on the community slack in a subset of columns used in an attempt to write. An existing test for this situation was not specific enough as this array has two dimensions and four attributions, and a four column object was written so we triggered the wrong error message. Now it gets us
$ ./exampleScript.R Error: Columns 'Low, Close' are missing. Please add them Execution halted $ which identifies the missing attributes by name.