Default sparse read via tiledb_array to UNORDERED#488
Merged
eddelbuettel merged 7 commits intomasterfrom Nov 29, 2022
Merged
Conversation
|
This pull request has been linked to Shortcut Story #23685: Performance issue running R query.. |
awenocur
approved these changes
Nov 28, 2022
KiterLuc
approved these changes
Nov 28, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the default query layout for read access via
tiledb_array()and the[accessor to 'UNORDERED' for sparse matrices (and 'ROW_MAJOR' for dense). The read setting now matches the[<-write access implementation.Unordered generally performs better, motivating the change. This is a change in behavior as seen by the handful of tests which needed updating.
As an illustration, here is a approximately seven-fold gain with a (local disk) array using the Deutsche Boerse (csv to sparse array) data set from a tutorial from last year:
$ ./exampleDBoerse.R test replications elapsed relative 1 a <- resNone[] 10 10.663 7.451 2 b <- resUnordered[] 10 1.431 1.000 $