Skip to content

PHPStan types#4

Merged
Tobion merged 2 commits intoTobion:masterfrom
cs278:phpstan-types
Mar 8, 2026
Merged

PHPStan types#4
Tobion merged 2 commits intoTobion:masterfrom
cs278:phpstan-types

Conversation

@cs278
Copy link
Copy Markdown
Contributor

@cs278 cs278 commented Nov 17, 2025 •
edited
Loading

Improve type information for PHPStan.

Tests pass:

$ vendor/bin/simple-phpunit 
PHPUnit 9.6.29 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.14
Configuration: /home/chris.smith/src/retry/phpunit.xml
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing 
..........                                                        10 / 10 (100%)

Time: 00:01.007, Memory: 6.00 MB

OK (10 tests, 18 assertions)

cs278 added 2 commits November 17, 2025 16:29
@cs278
Enhance type information for PHPStan
b7914db 
Primary motivation is to allow PHPStan to understand the return type
of a decorated callable.
@cs278
Update PHPUnit and bump minimum PHP
f844d7a
@cs278 cs278 marked this pull request as ready for review November 17, 2025 16:30
@Tobion Tobion merged commit 88b09aa into Tobion:master Mar 8, 2026
@Tobion
Copy link
Copy Markdown
Owner

Tobion commented Mar 8, 2026

Thank you @cs278

Tobion
Tobion reviewed Mar 8, 2026
View reviewed changes
Comment thread src/RetryConfigurator.php
@cs278 cs278 deleted the phpstan-types branch March 16, 2026 12:29
@cs278 cs278 mentioned this pull request Mar 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tobion Tobion Tobion left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cs278 @Tobion