Skip to content

Localize the file viewer return action - #772

Merged
luokerenx4 merged 1 commit into
devfrom
codex/localize-file-viewer-back
Jul 29, 2026
Merged

Localize the file viewer return action#772
luokerenx4 merged 1 commit into
devfrom
codex/localize-file-viewer-back

Conversation

@luokerenx4

Copy link
Copy Markdown
Contributor

Summary

  • move the file viewer Back label into the four checked-in UI locale catalogs
  • give the return button a target-specific accessible name and tooltip using the owning Workspace tag
  • extend the existing navigation regression to require that target context while preserving exact Session/workspace routing

Evidence

On the Simplified Chinese Demo path Tracked → stock-vst → power_buy_points_2026-06-02.md, the file viewer still rendered the English word Back. Its accessible name was also only Back, even though the action does not return to the previous page: it opens the file's owning Workspace. The destination existed only in a mouse tooltip.

The stale demo-ws-1 backlink identity visible on that route is already owned by open PR #749 and is intentionally not duplicated here. Once #749 lands, this button's target label will automatically use that corrected Workspace tag.

Verification

  • pnpm vitest run ui/src/pages/FileViewerPage.spec.tsx (2 passed)
  • cd ui && npx tsc -b
  • npx tsc --noEmit
  • pnpm test (3388 passed, 9 skipped)
  • pnpm -F open-alice-ui build:demo
  • real Simplified Chinese Demo route: visible label is 返回; accessible name and tooltip are 返回 demo-ws- on the current dev fixture

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openalice-demo Ready Ready Preview, Comment Jul 28, 2026 11:12pm

Request Review

@luokerenx4 luokerenx4 added area:workspace Workspace, Session, templates, or sidebar lifecycle theme:localization Interface localization or translated product copy workflow:parallel Autonomous parallel contribution; leave open for later acceptance labels Jul 29, 2026 — with ChatGPT Codex Connector
@luokerenx4
luokerenx4 merged commit 781851c into dev Jul 29, 2026
7 checks passed
@luokerenx4
luokerenx4 deleted the codex/localize-file-viewer-back branch July 29, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:workspace Workspace, Session, templates, or sidebar lifecycle theme:localization Interface localization or translated product copy workflow:parallel Autonomous parallel contribution; leave open for later acceptance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant