Localize the Market FX landing experience - #773
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
luokerenx4
added
area:market-data
ChatGPT Codex Connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
On the Simplified Chinese Demo
/marketroute, the sidebar and lower market-pulse section were translated, but the main page title, search box, and entire FX desk remained English. The result was a conspicuous language break in the primary Market landing path.Open PR #758 modifies only the Market sidebar search; this change covers the separate main-content
SearchBoxandMarketPagesurfaces.Verification
pnpm vitest run ui/src/pages/MarketPage.spec.tsx ui/src/components/market/SearchBox.spec.tsx(3 passed)cd ui && npx tsc -bnpx tsc --noEmitpnpm test(3391 passed, 9 skipped)pnpm -F open-alice-ui build:demo/market: verified localized page/FX copy, localized search placeholder and无匹配, then opened跨国宏观and confirmed/market/boards/global-macrowith the全球宏观heading