Update i18n-ignores.json#27874
Conversation
I have added two strings for Basque, since we can specify `one month` and `one year` with a single word (each).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR updates the i18n test ignores configuration file to add two new entries for Basque ( 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ghost/i18n/test/i18n-ignores.json`:
- Around line 71-80: Replace the generic FIXME comments in
ghost/i18n/test/i18n-ignores.json for the entries referencing eu/ghost.json keys
"{count} month_one" and "{count} year_one" with a concise linguistic
justification: state that Basque uses single-word forms for "one month" and "one
year" so the {count} variable is intentionally omitted in the _one plural forms;
ensure the comment mentions the specific keys and that this is a deliberate
language-specific omission for future maintainers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ad2612e0-6456-4dad-89c9-a2905bca27d3
📒 Files selected for processing (1)
ghost/i18n/test/i18n-ignores.json
|
Happy to get this merged so that we can move on the other translation, but could you please update the comment? You don't have to replicate the bad "there's probably a problem here" boilerplate! :) |
Added two strings to the list that should be ignored when checking the localisation, since Basque has a way to say one month and one year with a single word, and it would be odd to use the variable. In English it would be like saying `one one month`, and `one one year`, respectively.
|
Done, I think |
I have added two strings for Basque, since we can specify
one monthandone yearwith a single word (each).Please check your PR against these items: