Skip to content

Update i18n-ignores.json#27874

Merged
9larsons merged 2 commits into
TryGhost:mainfrom
xabirequejo:patch-1
May 19, 2026
Merged

Update i18n-ignores.json#27874
9larsons merged 2 commits into
TryGhost:mainfrom
xabirequejo:patch-1

Conversation

@xabirequejo
Copy link
Copy Markdown
Contributor

I have added two strings for Basque, since we can specify one month and one year with a single word (each).

Please check your PR against these items:

  • I've read and followed the Contributor Guide
  • I've explained my change
  • I've written an automated test to prove my change works

I have added two strings for Basque, since we can specify `one month` and `one year` with a single word (each).
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ca783ef7-cf45-48cd-b7e9-49fbf71b41c0

📥 Commits

Reviewing files that changed from the base of the PR and between 143e8cb and e9a1ab7.

📒 Files selected for processing (1)
  • ghost/i18n/test/i18n-ignores.json
✅ Files skipped from review due to trivial changes (1)
  • ghost/i18n/test/i18n-ignores.json

Walkthrough

This PR updates the i18n test ignores configuration file to add two new entries for Basque (eu/ghost.json) language translations. The changes add override rules to ignore unused variables in the {count} month_one and {count} year_one forms, each annotated with a FIXME comment indicating these ignores; the JSON file's trailing closing brace line was also adjusted.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update i18n-ignores.json' is vague and generic, using only a file name without describing the purpose or context of the update. Consider a more descriptive title like 'Add Basque exceptions for month/year singular forms in i18n-ignores.json' to clarify the change's purpose.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly explains the change: adding two Basque strings to i18n-ignores.json because Basque can express 'one month' and 'one year' with single words, directly relating to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ghost/i18n/test/i18n-ignores.json`:
- Around line 71-80: Replace the generic FIXME comments in
ghost/i18n/test/i18n-ignores.json for the entries referencing eu/ghost.json keys
"{count} month_one" and "{count} year_one" with a concise linguistic
justification: state that Basque uses single-word forms for "one month" and "one
year" so the {count} variable is intentionally omitted in the _one plural forms;
ensure the comment mentions the specific keys and that this is a deliberate
language-specific omission for future maintainers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ad2612e0-6456-4dad-89c9-a2905bca27d3

📥 Commits

Reviewing files that changed from the base of the PR and between 3b19f78 and 143e8cb.

📒 Files selected for processing (1)
  • ghost/i18n/test/i18n-ignores.json

Comment thread ghost/i18n/test/i18n-ignores.json
@xabirequejo xabirequejo mentioned this pull request May 14, 2026
3 tasks
@cathysarisky
Copy link
Copy Markdown
Member

Happy to get this merged so that we can move on the other translation, but could you please update the comment? You don't have to replicate the bad "there's probably a problem here" boilerplate! :)

Added two strings to the list that should be ignored when checking the localisation, since Basque has a way to say one month and one year with a single word, and it would be odd to use the variable. In English it would be like saying `one one month`, and `one one year`, respectively.
@xabirequejo
Copy link
Copy Markdown
Contributor Author

Done, I think

@9larsons 9larsons merged commit 9bd489c into TryGhost:main May 19, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants