Moved React version pins into the pnpm catalog#28317
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (15)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (12)
WalkthroughThis PR centralizes React and testing-library dependency version management across the monorepo by adding pnpm workspace catalog entries (main catalog for React 18 and a catalogs.react17 variant) and updating app package.json files to reference those catalogs via Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28317 +/- ##
=======================================
Coverage 73.70% 73.70%
=======================================
Files 1535 1535
Lines 130745 130745
Branches 15641 15641
=======================================
+ Hits 96361 96369 +8
+ Misses 33395 33389 -6
+ Partials 989 987 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- the React 18 (admin) vs React 17 (public bundles) split was inlined across ~14 package.json files with nothing enforcing which lane held which version - adds react/react-dom/@testing-library/react to the catalog, plus a react17 named catalog mirroring the existing eslint9/tailwind3 pattern, so the split is declared in one place - pure no-op for resolved versions: the lockfile diff only reshapes specifiers to catalog refs, no package resolution changes - makes the eventual React bump a single catalog decision rather than another opportunity to drift
9larsons
force-pushed
the
deps/react-catalog-split
branch
from
3a11a3e to
524f672
Compare
This was referenced Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React 18 (admin) vs React 17 (public bundles) split was inlined across ~14
package.jsonfiles with nothing enforcing which lane held which version. ESLint and Tailwind already express their version splits through named catalogs (eslint9,tailwind3); React was the one core split that didn't.This adds
react,react-dom, and@testing-library/reactto the catalog plus areact17named catalog, and points every consumer at the right entry. The eventual React bump then becomes a single catalog decision instead of another chance to drift.This is a no-op for resolved versions — the lockfile diff only reshapes specifiers into catalog refs; no package resolution changes.
^18.2.0peer ranges are intentionally left loose.