Skip to content

Cleaned up ghost/core's zod dependency to use the catalog#28320

Merged
9larsons merged 1 commit into
mainfrom
deps/zod-catalog
Jun 2, 2026
Merged

Cleaned up ghost/core's zod dependency to use the catalog#28320
9larsons merged 1 commit into
mainfrom
deps/zod-catalog

Conversation

@9larsons
Copy link
Copy Markdown
Contributor

@9larsons 9larsons commented Jun 2, 2026

ghost/core pinned zod inline at 4.1.12, which is exactly the catalog value. With catalogMode: strict, every other zod consumer already references the catalog; pointing ghost/core at catalog: keeps the version single-sourced.

Pure no-op: only the lockfile specifier changes, resolution is unchanged.

- ghost/core pinned zod inline at 4.1.12, which is exactly the catalog value
- with catalogMode: strict, every other zod consumer already references the catalog; pointing ghost/core at catalog: too keeps the version single-sourced
- pure no-op: only the lockfile specifier changes, resolution is unchanged
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

Walkthrough

The PR updates the zod dependency in ghost/core/package.json from a pinned version (4.1.12) to a catalog-based specification (catalog:), enabling centralized version management through the project's version catalog system. This aligns the dependency with the repository's package management strategy.

Possibly related PRs

  • TryGhost/Ghost#27902: Updates catalog resolution enforcement via catalogMode: strict, establishing the framework for catalog-based dependency specs in this PR.
  • TryGhost/Ghost#27870: Configures pnpm publish to rewrite catalog references before npm publishing, directly supporting the catalog spec introduced in this change.

Suggested reviewers

  • troyciesco
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating ghost/core's zod dependency to use the project's catalog system.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The pull request description clearly explains the change: updating ghost/core's zod dependency from a pinned inline version to use the catalog-based version spec for consistency with other zod consumers, resulting in a pure no-op lockfile change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deps/zod-catalog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@9larsons 9larsons enabled auto-merge (squash) June 2, 2026 18:50
@9larsons 9larsons merged commit ed5f11d into main Jun 2, 2026
53 checks passed
@9larsons 9larsons deleted the deps/zod-catalog branch June 2, 2026 19:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.70%. Comparing base (80b1fcf) to head (dd3946e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28320      +/-   ##
==========================================
- Coverage   73.70%   73.70%   -0.01%     
==========================================
  Files        1535     1535              
  Lines      130745   130745              
  Branches    15641    15641              
==========================================
- Hits        96369    96365       -4     
+ Misses      33413    33394      -19     
- Partials      963      986      +23     
Flag Coverage Δ
admin-tests 54.68% <ø> (ø)
e2e-tests 73.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant