Skip to content

Bumped @vitejs/plugin-react to 5.2.0 - #29138

Merged
9larsons merged 1 commit into
mainfrom
steve/pla-96-plugin-react-5
Jul 6, 2026
Merged

Bumped @vitejs/plugin-react to 5.2.0#29138
9larsons merged 1 commit into
mainfrom
steve/pla-96-plugin-react-5

Conversation

@9larsons

@9larsons 9larsons commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

ref https://linear.app/ghost/issue/PLA-96/spike-rolldown-vite-drop-in-build-benchmarks

What changed

Bumps the shared catalog entry @vitejs/plugin-react from 4.7.0 to 5.2.0 in pnpm-workspace.yaml (+ resulting pnpm-lock.yaml). No other files touched.

Why / behavior

  • Behavior-neutral under the current stock Vite 7.3.2 + Rollup toolchain. plugin-react v5 supports vite ^4|5|6|7|8. On stock Vite it stays on the Babel transform with the same automatic JSX runtime as 4.7.0 — verified below.
  • v5 only auto-enables the Oxc fast-refresh transform when it detects rolldown-vite. There is no rolldown-vite on main, so that path is inert here.
  • Landing this independently so the plugin bump is already in place ahead of the Rolldown migration (PLA-96 spike).

Consumers validated

@vitejs/plugin-react is pulled via catalog: by 8 workspaces (admin uses plugin-react-swc, unaffected):

App build test:unit
apps/shade ✅ 226 passed
apps/admin-x-design-system ✅ 23 passed
apps/admin-x-framework ✅ 436 passed
apps/portal ✅ 583 passed / 1 skipped
apps/comments-ui ✅ 252 passed
apps/signup-form (no test:unit)
apps/sodo-search (no test:unit)
apps/announcement-bar ✅ 1 passed

(portal / sodo-search / announcement-bar inherit the plugin via the shared apps/_shared/vite-public-app.mjs; comments-ui / signup-form via their own configs.)

Spot-checks

  • Automatic JSX runtime unchanged: built apps/shade/es/shade-app.js still emits import { jsxs, jsx } from "react/jsx-runtime";; comments-ui UMD retains jsx-runtime markers.
  • svgr icons still render: apps/shade/es/x-logo-*.js builds an SVG into a working React.createElement("svg", …) component.

Resolved as @vitejs/plugin-react@5.2.0(vite@7.3.2).

ref https://linear.app/ghost/issue/PLA-96/spike-rolldown-vite-drop-in-build-benchmarks

Behavior-neutral under stock Vite/Rollup (stays on the Babel transform, same
automatic JSX runtime as 4.7.0); v5 auto-enables the Oxc fast-refresh transform
only when it detects rolldown-vite. Landing this ahead of the Rolldown migration
so the plugin bump is already in place.
@cursor

cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@nx-cloud

nx-cloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit e8b977d

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 10m 48s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗
nx run-many -t test:unit -p @tryghost/admin-x-d... ✅ Succeeded 8m 48s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 2m 43s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 51s View ↗
nx run @tryghost/admin:build ✅ Succeeded 4m 31s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 58s View ↗
nx run-many -t lint -p ghost-monorepo,@tryghost... ✅ Succeeded 3m View ↗
Additional runs (7) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-06 18:19:48 UTC

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 12582a1e-23c1-48dd-8bda-0fffde7ca4e0

📥 Commits

Reviewing files that changed from the base of the PR and between 498d2a0 and e8b977d.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Walkthrough

This pull request updates the catalog version pin for @vitejs/plugin-react in pnpm-workspace.yaml from 4.7.0 to 5.2.0. No other files or exported entities are affected.

Changes

Compact Summary

Area Change
pnpm-workspace.yaml Bumped @vitejs/plugin-react catalog version from 4.7.0 to 5.2.0

Sequence Diagram(s)

Not applicable for this change.

Related PRs: None identified.

Suggested labels: dependencies

Suggested reviewers: None identified.


A tiny bump, a version anew,
One line changed, the plugin's due,
From four-point-seven to five-point-two,
The workspace catalog gets its cue. 🐰📦

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading @vitejs/plugin-react to 5.2.0.
Description check ✅ Passed The description is clearly related to the plugin bump and its reported validation, matching the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steve/pla-96-plugin-react-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.26%. Comparing base (1f42ca3) to head (e8b977d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29138      +/-   ##
==========================================
- Coverage   74.29%   74.26%   -0.04%     
==========================================
  Files        1565     1565              
  Lines      135738   135738              
  Branches    16459    16452       -7     
==========================================
- Hits       100845   100803      -42     
- Misses      33864    33935      +71     
+ Partials     1029     1000      -29     
Flag Coverage Δ
admin-tests 55.16% <ø> (-0.02%) ⬇️
e2e-tests 76.41% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons
9larsons merged commit 13c561f into main Jul 6, 2026
49 checks passed
@9larsons
9larsons deleted the steve/pla-96-plugin-react-5 branch July 6, 2026 19:52
@coderabbitai coderabbitai Bot mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant