Cleaned up dead Vite config and added forwardConsole - #29164
Conversation
no ref - removes build.commonjsOptions from the admin-x-framework vite factory and the empty build.rollupOptions.output in comments-ui — both no-ops under Vite 8 (Rolldown handles CJS natively) - adds server.forwardConsole (warn/error) to apps/admin so browser console warnings/errors surface in the dev-server terminal - leaves vite-tsconfig-paths in place (it's load-bearing for cross-package @src resolution when admin imports stats/posts source) - verified: admin + comments-ui + a framework consumer build clean; comments-ui UMD unchanged, 0 require/module leaks
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 10m 28s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 46s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-f... |
✅ Succeeded | 57s | View ↗ |
nx run @tryghost/activitypub:test:acceptance |
✅ Succeeded | 49s | View ↗ |
nx run @tryghost/comments-ui:test:acceptance |
✅ Succeeded | 35s | View ↗ |
nx run ghost:build:assets |
✅ Succeeded | 2s | View ↗ |
nx run-many -t lint -p @tryghost/admin-x-framew... |
✅ Succeeded | 19s | View ↗ |
Additional runs (2) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-07 20:31:35 UTC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis change updates Vite configuration in three apps. The shared Changes
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Vite 8 already forwards browser console warn/error to the terminal when it detects an AI agent is driving the dev server, and stays quiet for humans, so an explicit always-on setting only adds terminal noise for human devs - kept commented as a documented reminder of the opt-in and its tradeoff
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
2 participants
Post-Vite-8 config tidy that keeps
vite-tsconfig-pathsin place (it's load-bearing for cross-package@srcresolution when admin imports stats/posts source).Changes
apps/admin-x-framework/src/vite.ts: removebuild.commonjsOptions— no-op under Vite 8 (Rolldown handles CJS natively).apps/comments-ui/vite.config.mts: remove the emptybuild.rollupOptions.outputblock.apps/admin/vite.config.ts: addserver.forwardConsole: { logLevels: ['warn','error'] }— browser console warnings/errors surface in the dev-server terminal.Verification
admin + comments-ui + a framework consumer (posts) build clean; comments-ui UMD unchanged (0 leaked
require(/module.exports).vite-tsconfig-pathsintentionally untouched.