Fixed editors auto-reformatting Koenig files on save - #29181
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis pull request updates linting and formatting configuration. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
no ref - kg-default-nodes, kg-lexical-html-renderer, and koenig-lexical carry prettier as a devDependency purely for normalising HTML strings in test assertions - Zed enables prettier formatting per-package when it finds a prettier dependency, and with no prettier config in the repo it applies prettier defaults, rewriting whole files on save and polluting PRs with unrelated changes - a catch-all .prettierignore in each package switches off editor-driven prettier formatting without affecting the tests, which call the prettier API directly with explicit options - also added ./koenig/*/ to eslint.workingDirectories so the VS Code ESLint extension treats Koenig packages as separate working directories, matching the old Koenig repo's ./packages/*/ setting
kevinansfield
force-pushed
the
fix-koenig-editor-reformatting
branch
from
July 8, 2026 16:19
8d157f9 to
5f58f3f
Compare
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 10m 44s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 41s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
nx run-many -t test:unit -p @tryghost/kg-defaul... |
✅ Succeeded | 6m 21s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 53s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 3m 20s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 3s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 45s | View ↗ |
Additional runs (6) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-08 16:32:34 UTC
kevinansfield
enabled auto-merge (squash)
July 8, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no ref
Since the Koenig monorepo merge, editing a file under
koenig/in Zed rewrites the whole file on save (prettier defaults: double quotes, added brace spacing, trailing commas, 80-col wrapping), polluting PRs with unrelated changes. Other directories in the repo are unaffected, and the Koenig code itself is fine — the whole tree already passes ESLint's autofix with zero changes under the sameeslint-plugin-ghoststyle Ghost uses.The trigger is that
kg-default-nodes,kg-lexical-html-renderer, andkoenig-lexicalare the only packages in the repo withprettieras a devDependency (used purely to normalise HTML strings in test assertions). Zed enables prettier formatting per-package when it finds a prettier dependency, and with no prettier config anywhere it formats with prettier defaults..prettierignoreto each of the three packages so editor-driven prettier formatting is switched off exactly where the test-only dependency exists (respected by Zed, monorepo-aware, takes precedence over any root config). The tests are unaffected as they call the prettier API directly with explicit options../koenig/*/toeslint.workingDirectoriesin.vscode/settings.jsonso the VS Code ESLint extension treats Koenig packages as separate working directories, matching the old Koenig repo's./packages/*/setting and the existingapps/*/ghost/*entries.