Skip to content

Removed unnecessary option when initializing Mailgun client#29184

Merged
cmraible merged 1 commit into
mainfrom
remove-labs-from-mailgun-client
Jul 9, 2026
Merged

Removed unnecessary option when initializing Mailgun client#29184
cmraible merged 1 commit into
mainfrom
remove-labs-from-mailgun-client

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

no ref

This change should have no user impact.

labs was never used. Let's remove it, which fixes a type error.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 56d1cd15-19b5-4f7d-b298-b57413ba4f5b

📥 Commits

Reviewing files that changed from the base of the PR and between 23402ab and 384bdc8.

📒 Files selected for processing (2)
  • ghost/core/core/server/services/email-analytics/email-analytics-provider-mailgun.js
  • ghost/core/core/server/services/email-analytics/email-analytics-service-wrapper.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • ghost/core/core/server/services/email-analytics/email-analytics-provider-mailgun.js

Walkthrough

EmailAnalyticsServiceWrapper no longer imports labs and now constructs MailgunProvider with only config and settings. EmailAnalyticsProviderMailgun also now constructs MailgunClient with only config and settings. No other email analytics control flow is changed.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing an unnecessary Mailgun initialization option.
Description check ✅ Passed The description is directly related to the change and correctly notes that removing unused labs fixes a type error.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-labs-from-mailgun-client

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 384bdc8

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 2m 4s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 52s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 5s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 29s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 23s View ↗
nx run-many -t lint -p ghost ✅ Succeeded 38s View ↗
nx run @tryghost/admin:build ✅ Succeeded 7s View ↗
Additional runs (2) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-09 15:07:35 UTC

coderabbitai[bot]

This comment was marked as resolved.

no ref

This change should have no user impact.

`labs` was never used. Let's remove it, which fixes a type error.
@EvanHahn EvanHahn force-pushed the remove-labs-from-mailgun-client branch from 23402ab to 384bdc8 Compare July 9, 2026 14:57
@cursor

cursor Bot commented Jul 9, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@EvanHahn EvanHahn requested a review from cmraible July 9, 2026 15:13
@cmraible cmraible merged commit ca6dbfa into main Jul 9, 2026
44 checks passed
@cmraible cmraible deleted the remove-labs-from-mailgun-client branch July 9, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants