Conversation
ref [ONC-1864](https://linear.app/ghost/issue/ONC-1864/incorrect-email-displayed-in-need-help-portion-of-portal) This part of the FAQ is confusing for members, who are being directed to email the newsletter address. This address is often a no-reply, or inaccessible by the site owner. The impact of sending the email is still useful (it sends a signal to the recipient's ESP that they do want to receive emails from that address), but it's a hack.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (64)
💤 Files with no reviewable changes (64)
WalkthroughThis PR removes the "Send an email and say hi!" FAQ step from the email-receiving-faq portal component, along with its Interpolate-based explanatory paragraph. Correspondingly, the associated i18n message keys ("Send an email and say hi!" and "Send an email to {senderEmail} and say hello...") are removed from Possibly related issues
Suggested labels: `affects:i18n` Suggested reviewers: `cathysarisky` 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 10m 51s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 44s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 48s | View ↗ |
nx run-many -t lint -p @tryghost/portal,@trygho... |
✅ Succeeded | 1m 24s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 56s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 31s | View ↗ |
nx run @tryghost/comments-ui:test:acceptance |
✅ Succeeded | 44s | View ↗ |
Additional runs (5) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-09 13:21:34 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref ONC-1864
This part of the FAQ is confusing for members, who are being directed to email the newsletter address. This address is often a no-reply, or inaccessible by the site owner. The impact of sending the email is still useful (it sends a signal to the recipient's ESP that they do want to receive emails from that address), but it's a hack.