Skip to content

Disabled Nx native command runner for the build artifacts job - #29210

Merged
9larsons merged 1 commit into
mainfrom
slars/nx-native-command-runner-19fb05
Jul 9, 2026
Merged

Disabled Nx native command runner for the build artifacts job#29210
9larsons merged 1 commit into
mainfrom
slars/nx-native-command-runner-19fb05

Conversation

@9larsons

@9larsons 9larsons commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

no ref

The Build & Publish Artifacts job's Build server and admin assets step has intermittently segfaulted before Nx starts the target script — nx run ghost:build:tsc is killed with SIGSEGV roughly a second in, before Nx or tsc produce any output (e.g. run #49431).

This sets NX_NATIVE_COMMAND_RUNNER: "false" on that step's env, which keeps Nx orchestration and caching but avoids its native PTY command runner. It mirrors the same fix already applied to the acceptance test job in 2798ba3; there it lives at the job level because that job already had a job-level env: block, whereas here the failing step already carries its own env:, so scoping it to that step keeps it targeted to the exact command that crashes.

The "Build server and admin assets" step has intermittently segfaulted
before Nx starts the target script (SIGSEGV on `nx run ghost:build:tsc`).
Keep Nx orchestration but avoid its native PTY runner, matching the fix
already applied to the acceptance test job.
@nx-cloud

nx-cloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit dd0fdcf

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 11m 3s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 5s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 16s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 59s View ↗
nx run @tryghost/koenig-lexical:test:acceptance ✅ Succeeded 2m 22s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 6s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 1s View ↗
nx run @tryghost/activitypub:test:acceptance ✅ Succeeded 48s View ↗
Additional runs (10) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-09 18:03:32 UTC

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

This change modifies the CI workflow configuration file to add an environment variable, NX_NATIVE_COMMAND_RUNNER: "false", to the "Build server and admin assets" step within the job_build_artifacts job. This setting disables Nx's native PTY runner for that specific step, along with accompanying explanatory comments. No exported or public entities were altered.

Possibly related PRs

  • TryGhost/Ghost#28843: Both PRs modify the same CI workflow file around Nx-related CI behavior.
  • TryGhost/Ghost#29154: Applies the same NX_NATIVE_COMMAND_RUNNER="false" fix to address Nx native runner segfaults, but for the acceptance tests job instead of job_build_artifacts.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly states the main change: disabling Nx's native command runner for the build artifacts job.
Description check ✅ Passed The description is directly related to the change and explains the segfault fix and step-level scope.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slars/nx-native-command-runner-19fb05

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@9larsons
9larsons enabled auto-merge (squash) July 9, 2026 17:57
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (83a5b36) to head (dd0fdcf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29210      +/-   ##
==========================================
+ Coverage   74.04%   74.07%   +0.02%     
==========================================
  Files        1570     1570              
  Lines      136624   136624              
  Branches    16524    16530       +6     
==========================================
+ Hits       101165   101203      +38     
+ Misses      34423    34385      -38     
  Partials     1036     1036              
Flag Coverage Δ
e2e-tests 76.18% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons
9larsons merged commit 7ea4b72 into main Jul 9, 2026
52 checks passed
@9larsons
9larsons deleted the slars/nx-native-command-runner-19fb05 branch July 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant