Removed dead marked and debug dependencies from kg-simplemde - #29225
Conversation
no ref - kg-simplemde is a vendored SimpleMDE fork; both deps are unreferenced - marked: the only source reference is a commented-out require plus `var marked;` (undefined) and an `if(marked)` guard that is therefore always false — it was deliberately disabled to reduce filesize, so the dep is dead - debug: no live require; the `debug` tokens in gulpfile.js all refer to the separate gulp-debug package and to task/output names, not this package
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 11m 12s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
nx run-many -t test:unit -p @tryghost/koenig-le... |
✅ Succeeded | 8m 55s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 47s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 45s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 7s | View ↗ |
nx run-many -t lint -p @tryghost/kg-simplemde,@... |
✅ Succeeded | 3m 24s | View ↗ |
nx run @tryghost/koenig-lexical:test:acceptance |
✅ Succeeded | 2m 46s | View ↗ |
Additional runs (11) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-09 21:50:43 UTC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe SimpleMDE package manifest removes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29225 +/- ##
=======================================
Coverage 74.07% 74.07%
=======================================
Files 1570 1570
Lines 136625 136625
Branches 16532 16535 +3
=======================================
+ Hits 101205 101211 +6
- Misses 34384 34410 +26
+ Partials 1036 1004 -32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Why
kg-simplemdeis a vendored SimpleMDE fork carrying two dependencies that nothing uses. Found during adepcheckaudit of koenig packages.What
marked(dependency) — the only source reference is a commented-outrequire(// var marked = require("marked");) followed byvar marked;(undefined) and anif(marked)guard that is therefore always false. It was deliberately disabled ("disable marked to reduce filesize - Ghost uses its own renderer"), so the package is dead weight.debug(devDependency) — no liverequire('debug'). Thedebugtokens ingulpfile.jsall refer to the separategulp-debugpackage and to task/output-dir names, not this package.Notes
Vendored package with no
test/lint/buildnpm scripts (build is a checked-in gulp pipeline), so verification is by source inspection — confirmed neither dep is referenced anywhere insrc/orgulpfile.js. Left the rest of the vendored gulp toolchain untouched.