Skip to content

Removed dead marked and debug dependencies from kg-simplemde - #29225

Merged
9larsons merged 1 commit into
mainfrom
slars/koenig-simplemde-deps
Jul 9, 2026
Merged

Removed dead marked and debug dependencies from kg-simplemde#29225
9larsons merged 1 commit into
mainfrom
slars/koenig-simplemde-deps

Conversation

@9larsons

@9larsons 9larsons commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

kg-simplemde is a vendored SimpleMDE fork carrying two dependencies that nothing uses. Found during a depcheck audit of koenig packages.

What

  • marked (dependency) — the only source reference is a commented-out require (// var marked = require("marked");) followed by var marked; (undefined) and an if(marked) guard that is therefore always false. It was deliberately disabled ("disable marked to reduce filesize - Ghost uses its own renderer"), so the package is dead weight.
  • debug (devDependency) — no live require('debug'). The debug tokens in gulpfile.js all refer to the separate gulp-debug package and to task/output-dir names, not this package.

Notes

Vendored package with no test/lint/build npm scripts (build is a checked-in gulp pipeline), so verification is by source inspection — confirmed neither dep is referenced anywhere in src/ or gulpfile.js. Left the rest of the vendored gulp toolchain untouched.

no ref

- kg-simplemde is a vendored SimpleMDE fork; both deps are unreferenced
- marked: the only source reference is a commented-out require plus
  `var marked;` (undefined) and an `if(marked)` guard that is therefore always
  false — it was deliberately disabled to reduce filesize, so the dep is dead
- debug: no live require; the `debug` tokens in gulpfile.js all refer to the
  separate gulp-debug package and to task/output names, not this package
@nx-cloud

nx-cloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit b8dab61

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 11m 12s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 1s View ↗
nx run-many -t test:unit -p @tryghost/koenig-le... ✅ Succeeded 8m 55s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 2m 47s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 45s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 7s View ↗
nx run-many -t lint -p @tryghost/kg-simplemde,@... ✅ Succeeded 3m 24s View ↗
nx run @tryghost/koenig-lexical:test:acceptance ✅ Succeeded 2m 46s View ↗
Additional runs (11) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-09 21:50:43 UTC

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e611793c-e2c3-4e25-ad51-f8eb41d5c8ce

📥 Commits

Reviewing files that changed from the base of the PR and between e9a2c88 and b8dab61.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • koenig/kg-simplemde/package.json

Walkthrough

The SimpleMDE package manifest removes debug and marked from its development dependencies and updates the trailing entry formatting for codemirror-spell-checker.

Suggested reviewers: EvanHahn, acburdine

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the removal of unused dependencies from kg-simplemde.
Description check ✅ Passed The description is directly related and accurately explains why the unused dependencies were removed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch slars/koenig-simplemde-deps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@9larsons
9larsons enabled auto-merge (squash) July 9, 2026 21:42
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (f30b7b3) to head (b8dab61).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29225   +/-   ##
=======================================
  Coverage   74.07%   74.07%           
=======================================
  Files        1570     1570           
  Lines      136625   136625           
  Branches    16532    16535    +3     
=======================================
+ Hits       101205   101211    +6     
- Misses      34384    34410   +26     
+ Partials     1036     1004   -32     
Flag Coverage Δ
admin-tests 55.20% <ø> (+0.01%) ⬆️
e2e-tests 76.19% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@9larsons
9larsons merged commit 9cf006e into main Jul 9, 2026
52 checks passed
@9larsons
9larsons deleted the slars/koenig-simplemde-deps branch July 9, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant