Skip to content

Dropped email_tracked_sent_count column from automation action revisions#29322

Merged
cmraible merged 1 commit into
mainfrom
chris-ny-1463-drop-automated_email_recipientsemail_tracked_sent_count
Jul 20, 2026
Merged

Dropped email_tracked_sent_count column from automation action revisions#29322
cmraible merged 1 commit into
mainfrom
chris-ny-1463-drop-automated_email_recipientsemail_tracked_sent_count

Conversation

@cmraible

@cmraible cmraible commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

closes https://linear.app/ghost/issue/NY-1463/drop-email-tracked-sent-count-column

Open rates now use total sent as their denominator, making the tracked-only aggregate redundant and potentially confusing — let's drop the column.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e56dd788-3d30-4a39-ae89-09b80723e951

📥 Commits

Reviewing files that changed from the base of the PR and between baca12b and db0c6b4.

📒 Files selected for processing (5)
  • ghost/admin/package.json
  • ghost/core/core/server/data/migrations/versions/6.54/2026-07-20-13-59-21-drop-email-tracked-sent-count-from-automation-action-revisions.js
  • ghost/core/core/server/data/schema/schema.js
  • ghost/core/package.json
  • ghost/core/test/unit/server/data/schema/integrity.test.js
🚧 Files skipped from review as they are similar to previous changes (2)
  • ghost/core/core/server/data/schema/schema.js
  • ghost/core/test/unit/server/data/schema/integrity.test.js

Walkthrough

Removes the email_tracked_sent_count column from the automation action revisions schema and adds a migration to drop it from existing databases. Updates the expected database schema integrity hash and bumps the ghost-admin and ghost-core package versions to 6.54.0-rc.0.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: dropping the tracked sent count column.
Description check ✅ Passed The description matches the change by explaining why the redundant column is being removed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chris-ny-1463-drop-automated_email_recipientsemail_tracked_sent_count

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
ghost/admin/package.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

ghost/core/package.json

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the migration [pull request] Includes migration for review label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@cmraible cmraible changed the title Removed obsolete tracked automation email count Dropped email_tracked_sent_count column from automation action revisions Jul 14, 2026
@nx-cloud

nx-cloud Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit db0c6b4

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 2m 18s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 3s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 10s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 41s View ↗
nx run ghost-admin:test ✅ Succeeded 2m 48s View ↗
nx run @tryghost/admin:build ✅ Succeeded 1m 46s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 20s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 30s View ↗
Additional runs (2) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-20 14:21:19 UTC

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.53%. Comparing base (1f2fc31) to head (db0c6b4).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29322      +/-   ##
==========================================
+ Coverage   74.41%   74.53%   +0.11%     
==========================================
  Files        1602     1602              
  Lines      140269   140399     +130     
  Branches    17047    17065      +18     
==========================================
+ Hits       104386   104643     +257     
+ Misses      34861    34700     -161     
- Partials     1022     1056      +34     
Flag Coverage Δ
e2e-tests 76.62% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmraible
cmraible force-pushed the chris-ny-1463-drop-automated_email_recipientsemail_tracked_sent_count branch 3 times, most recently from 78a7e32 to baca12b Compare July 16, 2026 17:02
@cmraible
cmraible marked this pull request as ready for review July 16, 2026 18:00
@cmraible

Copy link
Copy Markdown
Collaborator Author

Tested manually on MySQL and Sqlite. Did not test on staging because this is a simple drop column on a table that should have no more than 1000 rows.

@cmraible
cmraible requested a review from EvanHahn July 16, 2026 18:01
closes https://linear.app/ghost/issue/NY-1463/drop-email-tracked-sent-count-column

Open rates now use total sent count, so the separate tracked aggregate is unnecessary.
@cmraible
cmraible force-pushed the chris-ny-1463-drop-automated_email_recipientsemail_tracked_sent_count branch from baca12b to db0c6b4 Compare July 20, 2026 14:11
@cmraible
cmraible enabled auto-merge (squash) July 20, 2026 14:22
@cmraible
cmraible merged commit b861187 into main Jul 20, 2026
43 checks passed
@cmraible
cmraible deleted the chris-ny-1463-drop-automated_email_recipientsemail_tracked_sent_count branch July 20, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants