Skip to content

Disabled coverage on fork repos - #29325

Merged
acburdine merged 1 commit into
mainfrom
ci/disable-coverage
Jul 14, 2026
Merged

Disabled coverage on fork repos#29325
acburdine merged 1 commit into
mainfrom
ci/disable-coverage

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • ensure coverage steps don't run on forked repos since coverage isn't used from them anyways

@acburdine
acburdine requested a review from 9larsons July 14, 2026 18:09
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 61ab7fcd-157d-4888-9e95-a0c90c964d31

📥 Commits

Reviewing files that changed from the base of the PR and between b2aa910 and 0d00a9f.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • ghost/core/package.json
💤 Files with no reviewable changes (1)
  • ghost/core/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/ci.yml

Walkthrough

The CI workflow adds a repository-specific coverage_enabled output and uses it to conditionally run admin, acceptance, artifact upload, and coverage aggregation steps. Acceptance coverage is limited to the SQLite matrix leg. The Nx configuration removes the E2E and integration no-coverage targets.

Possibly related PRs

Suggested reviewers: 9larsons

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: disabling coverage on forked repositories.
Description check ✅ Passed The description is directly related to the change and explains why coverage is skipped on forks.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/disable-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@acburdine
acburdine enabled auto-merge (squash) July 14, 2026 18:09
@nx-cloud

nx-cloud Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit b2aa910

Command Status Duration Result
nx run ghost-admin:test ✅ Succeeded 3s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-14 18:33:37 UTC

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 267-272: Update the coverage_enabled expression in the CI workflow
to compare github.event.pull_request.head.repo.full_name with the canonical
repository for pull_request events, while retaining a canonical-repository check
using github.repository for non-PR runs. Ensure fork pull requests evaluate to
false and canonical repository runs retain coverage and Codecov uploads.
- Around line 1675-1680: Update the job-level condition for job_coverage to
include always() while preserving the existing coverage_enabled check. Keep the
current per-step result checks unchanged so coverage artifacts from completed
test jobs are still uploaded when other test jobs are skipped.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6a443634-c43f-49c4-864e-584a00cb37c4

📥 Commits

Reviewing files that changed from the base of the PR and between 0994574 and b2aa910.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • ghost/core/package.json
💤 Files with no reviewable changes (1)
  • ghost/core/package.json

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml Outdated
no ref
- ensure coverage steps don't run on forked repos since coverage isn't used from them anyways
@acburdine
acburdine force-pushed the ci/disable-coverage branch from b2aa910 to 0d00a9f Compare July 14, 2026 18:16
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.98%. Comparing base (50b6f7c) to head (0d00a9f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29325      +/-   ##
==========================================
+ Coverage   73.93%   73.98%   +0.05%     
==========================================
  Files        1579     1579              
  Lines      136891   136893       +2     
  Branches    16552    16573      +21     
==========================================
+ Hits       101204   101276      +72     
+ Misses      34678    34575     -103     
- Partials     1009     1042      +33     
Flag Coverage Δ
e2e-tests 76.07% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acburdine
acburdine merged commit 4a64c91 into main Jul 14, 2026
96 of 98 checks passed
@acburdine
acburdine deleted the ci/disable-coverage branch July 14, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant