Changed route settings service API names to upload and download

[vershwal]

ref https://linear.app/ghost/issue/HKG-1830

• the service methods now carry the names of the Admin API operations they back: get was ambiguous sitting next to store.get(), and setFromFilePath describes a transport detail rather than what the caller is doing
• mechanical rename only — signatures and behavior are unchanged, and upload still takes the multer tmp-file path; moving the file read to the API boundary (so the service's only I/O is the configured store) ships separately on top of this

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b5050c6d-badc-4f95-a5b8-2545ffc1e117

📥 Commits

Reviewing files that changed from the base of the PR and between 24579d9 and 0ec451e.

📒 Files selected for processing (4)

• ghost/core/core/server/api/endpoints/settings.js
• ghost/core/core/server/services/route-settings/dynamic-routing-service.js
• ghost/core/core/server/services/route-settings/index.js
• ghost/core/test/unit/server/services/route-settings/dynamic-routing-service.test.ts

🚧 Files skipped from review as they are similar to previous changes (3)

• ghost/core/core/server/services/route-settings/index.js
• ghost/core/core/server/api/endpoints/settings.js
• ghost/core/test/unit/server/services/route-settings/dynamic-routing-service.test.ts

---

Walkthrough

Renames DynamicRoutingService methods from get and setFromFilePath to download and upload. Updates route-settings API delegation getters and settings endpoints to use the new names. Adjusts unit tests for retrieval, fallback, validation, persistence, corrupt store content, and frontend reload failure scenarios.

Possibly related PRs

• TryGhost/Ghost#28965: Modifies the original route-settings service API used by this rename.
• TryGhost/Ghost#29305: Contains related store-backed route-settings interface and delegation changes.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: renaming the route settings API methods to upload and download.
Description check	✅ Passed	The description matches the changeset and correctly explains the mechanical rename and unchanged behavior.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch renameUploadDownload

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit 24579d9

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	1m 54s	View ↗
nx run ghost:test:integration	✅ Succeeded	2m 51s	View ↗
nx run ghost:test:legacy	✅ Succeeded	2m 59s	View ↗
nx run ghost:test:e2e	✅ Succeeded	2m 32s	View ↗
nx run ghost-monorepo:lint:boundaries	✅ Succeeded	19s	View ↗
nx run-many -t test:unit -p ghost	✅ Succeeded	30s	View ↗
nx run-many -t lint -p ghost,ghost-monorepo	✅ Succeeded	23s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	7s	View ↗
nx run-many --target=build --projects=tag:publi...	✅ Succeeded	<1s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-07-15 18:39:29 UTC

[Copilot]

Pull request overview

Renames the route settings service API methods to align with the Admin API operations they back (upload/download), updating the service, API endpoint usage, and unit tests accordingly.

Changes:

• Renamed DynamicRoutingService.get() → download() and setFromFilePath() → upload().
• Updated the settings API endpoint handlers to call routeSettings.api.upload() / routeSettings.api.download().
• Updated unit tests to use the new method names.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
ghost/core/test/unit/server/services/route-settings/dynamic-routing-service.test.ts	Updates unit tests to use download/upload method names.
ghost/core/core/server/services/route-settings/index.js	Renames the exported api method accessors to upload/download (potential compatibility concern noted in review comment).
ghost/core/core/server/services/route-settings/dynamic-routing-service.js	Renames service methods to download/upload while keeping behavior intact.
ghost/core/core/server/api/endpoints/settings.js	Updates API endpoint wiring to call the renamed route-settings API methods.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.04%. Comparing base (77790bf) to head (0ec451e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #29364      +/-   ##
==========================================
+ Coverage   74.01%   74.04%   +0.02%     
==========================================
  Files        1578     1578              
  Lines      137508   137508              
  Branches    16648    16652       +4     
==========================================
+ Hits       101772   101812      +40     
+ Misses      34691    34681      -10     
+ Partials     1045     1015      -30     

Flag	Coverage Δ
e2e-tests	76.12% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.