Skip to content

Moved newsletter Ghost orb to Shade - #29382

Merged
9larsons merged 1 commit into
mainfrom
codex/migrate-ghost-orb
Jul 16, 2026
Merged

Moved newsletter Ghost orb to Shade#29382
9larsons merged 1 commit into
mainfrom
codex/migrate-ghost-orb

Conversation

@9larsons

Copy link
Copy Markdown
Contributor

What changed

  • Switched the newsletter preview GhostOrb import from admin-x-design-system to @tryghost/shade/components.
  • Removed the now-unused admin-x-design-system GhostOrb export.
  • Deleted the duplicate legacy SVG asset.

Why

Shade already owns a byte-for-byte identical Ghost orb SVG. Using the Shade export removes the final consumer and shrinks the legacy design-system surface without changing markup, styling, or runtime behavior.

Validation

  • Independent agent review: no findings
  • Legacy and Shade SVGs confirmed byte-for-byte identical
  • admin-x-settings: 203 unit tests passed
  • admin-x-design-system: 23 unit tests passed
  • Full lint and TypeScript checks for both packages
  • admin-x-design-system and Shade production builds
  • git diff --check

Manual testing

  • Open Settings → Email newsletters and edit a newsletter.
  • Enable Show badge in the newsletter design preview.
  • Confirm the 16px Ghost orb and “Powered by Ghost” render unchanged.
  • Toggle the badge off and on.
  • Ideally verify the orb inherits the expected footer color in both light and dark configurations.

no ref

Shade already owns the identical Ghost orb asset, so keeping a second design-system export left an unnecessary legacy dependency.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46ea8047-1c54-44ae-b1ca-ca00c8fa1779

📥 Commits

Reviewing files that changed from the base of the PR and between 56bfb58 and cc8b4ec.

⛔ Files ignored due to path filters (1)
  • apps/admin-x-design-system/src/assets/images/ghost-orb.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • apps/admin-x-design-system/src/index.ts
  • apps/admin-x-settings/src/components/settings/email/newsletters/newsletter-preview-content.tsx
💤 Files with no reviewable changes (1)
  • apps/admin-x-design-system/src/index.ts

Walkthrough

Removed the GhostOrb export from the admin design-system barrel. Updated the newsletter preview component to import GhostOrb from @tryghost/shade/components while continuing to import Icon from @tryghost/admin-x-design-system.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: moving the newsletter Ghost orb to Shade.
Description check ✅ Passed The description is directly related to the changeset and accurately explains what changed and why.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/migrate-ghost-orb

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 16, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit cc8b4ec

Command Status Duration Result
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 6m 19s View ↗
nx run @tryghost/admin:test:acceptance ✅ Succeeded 3m 23s View ↗
nx run-many -t test:unit -p @tryghost/admin-x-d... ✅ Succeeded 2m 11s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 20s View ↗
nx run-many -t lint -p @tryghost/admin-x-design... ✅ Succeeded 1m 19s View ↗
nx run @tryghost/admin:build ✅ Succeeded 51s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-16 13:23:37 UTC

@9larsons
9larsons marked this pull request as ready for review July 16, 2026 13:19
@9larsons
9larsons enabled auto-merge (squash) July 16, 2026 13:19
@9larsons
9larsons merged commit 799afac into main Jul 16, 2026
43 checks passed
@9larsons
9larsons deleted the codex/migrate-ghost-orb branch July 16, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant