Skip to content

Improved name for newsletter analytics helper - #29398

Merged
cmraible merged 1 commit into
mainfrom
ny1474-rename-emaileventstorage
Jul 16, 2026
Merged

Improved name for newsletter analytics helper#29398
cmraible merged 1 commit into
mainfrom
ny1474-rename-emaileventstorage

Conversation

@EvanHahn

Copy link
Copy Markdown
Contributor

closes https://linear.app/ghost/issue/NY-1474

This change should have no user impact, and is just a rename for clarity.

closes https://linear.app/ghost/issue/NY-1474

This change should have no user impact, and is just a rename.
@EvanHahn
EvanHahn requested a review from cmraible July 16, 2026 16:46
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a70db97e-9f58-469b-ab0c-23536e9458f2

📥 Commits

Reviewing files that changed from the base of the PR and between 019e575 and bf187b3.

📒 Files selected for processing (6)
  • ghost/core/core/server/services/email-analytics/index.ts
  • ghost/core/core/server/services/email-service/email-event-processor.js
  • ghost/core/core/server/services/email-service/newsletter-email-event-storage.js
  • ghost/core/test/integration/services/email-service/newsletter-email-event-storage.test.js
  • ghost/core/test/integration/services/mailgun-email-suppression-list.test.js
  • ghost/core/test/unit/server/services/email-service/newsletter-email-event-storage.test.js

Walkthrough

Renames the newsletter email event storage class and export to NewsletterEmailEventStorage, updates its JSDoc contract, and wires the newsletter email analytics processor to use it. Unit and integration tests update imports, instantiations, suite labels, and an isolation comment while preserving existing assertions and event-handling coverage.

Possibly related PRs

  • TryGhost/Ghost#29333: Updates newsletter email analytics wiring and the event storage used during processor construction.

Suggested reviewers: cmraible

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change as a rename for the newsletter analytics helper.
Description check ✅ Passed The description matches the changeset and correctly states it is a clarity-focused rename with no user impact.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ny1474-rename-emaileventstorage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 16, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit bf187b3

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 1m 54s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 10s View ↗
nx run ghost:test:legacy ✅ Succeeded 3m 4s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 31s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 20s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 19s View ↗
nx run @tryghost/admin:build ✅ Succeeded 8s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-16 16:56:00 UTC

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.15%. Comparing base (8c3e2b7) to head (bf187b3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29398      +/-   ##
==========================================
+ Coverage   74.13%   74.15%   +0.01%     
==========================================
  Files        1592     1592              
  Lines      138690   138767      +77     
  Branches    16822    16840      +18     
==========================================
+ Hits       102824   102900      +76     
+ Misses      34851    34822      -29     
- Partials     1015     1045      +30     
Flag Coverage Δ
e2e-tests 76.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmraible
cmraible merged commit 88a1a1d into main Jul 16, 2026
46 checks passed
@cmraible
cmraible deleted the ny1474-rename-emaileventstorage branch July 16, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants