Removed legacy settings acceptance test plumbing - #29403
Merged
Merged
Conversation
ref https://linear.app/ghost/issue/PLA-243 - all settings acceptance coverage now runs in Admin - removing the standalone target prevents CI from carrying an empty legacy lane - shared Playwright helpers remain for ActivityPub
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (32)
💤 Files with no reviewable changes (27)
WalkthroughThe change removes the standalone settings-app bootstrap, public wrapper export, Playwright scripts and configuration, related fixtures, and test assets. Shared framework acceptance support is reduced to core API mocking and two statistics fixtures, and its test-data dependency is removed. The theme acceptance test uses a new archive fixture path. PostCSS configuration wiring and explanatory comments are updated. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 49s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-d... |
✅ Succeeded | 7m 26s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 54s | View ↗ |
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 4m 55s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 21s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 20s | View ↗ |
nx run-many -t lint -p @tryghost/admin-x-design... |
✅ Succeeded | 3m 10s | View ↗ |
nx run @tryghost/koenig-lexical:test:acceptance |
✅ Succeeded | 2m 33s | View ↗ |
Additional runs (8) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-16 17:52:52 UTC
9larsons
marked this pull request as ready for review
July 16, 2026 17:52
9larsons
enabled auto-merge (squash)
July 16, 2026 17:53
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29403 +/- ##
==========================================
- Coverage 74.17% 74.17% -0.01%
==========================================
Files 1592 1592
Lines 139000 139000
Branches 16866 16861 -5
==========================================
- Hits 103109 103106 -3
- Misses 34872 34876 +4
+ Partials 1019 1018 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@tryghost/admin-x-settingsPlaywright target, scripts, tag, config, and final skipped placeholderStandaloneAppwrappermockApiand Admin analytics fixturesWhy
All Settings acceptance coverage now runs in Admin's browser-mode suite. Keeping an empty standalone target required a fake test and continued scheduling a legacy CI lane. This teardown is the hard gate before moving Settings source into Admin under PLA-243.
Validation
pnpm nx run @tryghost/admin-x-settings:test:unit— 205 passedpnpm nx run @tryghost/admin-x-settings:lintpnpm --filter @tryghost/admin-x-framework buildpnpm --filter @tryghost/admin-x-framework lintpnpm --filter @tryghost/activitypub test:acceptance— 31 passedpnpm nx run admin:buildpnpm --filter admin test:acceptance— 325 passedref https://linear.app/ghost/issue/PLA-243