Skip to content

Fixed ordering of adapter resolution#29494

Merged
acburdine merged 1 commit into
mainfrom
fix/resolution-ordering
Jul 21, 2026
Merged

Fixed ordering of adapter resolution#29494
acburdine merged 1 commit into
mainfrom
fix/resolution-ordering

Conversation

@acburdine

Copy link
Copy Markdown
Member

no ref

  • ensure adapters installed in content/adapters are loaded last, so they don't accidentally shadow any internal or platform-installed adapters

no ref
- ensure adapters installed in content/adapters are loaded last, so they don't accidentally shadow any internal or platform-installed adapters
@acburdine
acburdine force-pushed the fix/resolution-ordering branch from 42ffc52 to 697e0e0 Compare July 21, 2026 15:59
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d23ce56e-af71-4c80-98b8-96074fbdcb26

📥 Commits

Reviewing files that changed from the base of the PR and between 6d1f6e7 and 697e0e0.

📒 Files selected for processing (1)
  • ghost/core/core/server/services/adapter-manager/index.ts

Walkthrough

The adapter manager now orders adapter lookup paths with internal adapters first, optional installed adapters second, and content adapters last. This changes adapter resolution precedence without altering exported or public entities.

Possibly related PRs

  • TryGhost/Ghost#29487: Both changes modify adapter path construction and ordering in the adapter manager.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adapter resolution ordering was adjusted.
Description check ✅ Passed The description matches the changeset and explains the adapter-loading order change.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/resolution-ordering

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 21, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 697e0e0

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 3m 2s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 11s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 40s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-21 16:29:03 UTC

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.56%. Comparing base (6d1f6e7) to head (697e0e0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29494      +/-   ##
==========================================
- Coverage   74.60%   74.56%   -0.04%     
==========================================
  Files        1604     1604              
  Lines      140899   140903       +4     
  Branches    17212    17200      -12     
==========================================
- Hits       105111   105059      -52     
- Misses      34729    34811      +82     
+ Partials     1059     1033      -26     
Flag Coverage Δ
e2e-tests 76.64% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@acburdine
acburdine merged commit c97ed3c into main Jul 21, 2026
85 of 88 checks passed
@acburdine
acburdine deleted the fix/resolution-ordering branch July 21, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant