Moved ghost/admin to apps/ember-admin - #29526
Merged
Merged
Conversation
acburdine
commented
Jul 22, 2026
acburdine
commented
Member
- part of pulling non-core code out of the ghost/ folder so its contents can be reorganised; the Ember admin is a frontend app and belongs alongside the other apps/*
- nx/npm package name stays ghost-admin, so every nx project reference (@tryghost/admin build chain, ci.yml, root scripts, vscode tasks) keeps working untouched
- fixed the paths that are genuinely directory-relative rather than project-name-based: apps/admin vite ember-assets sibling path, the ember-admin nx dev cwd, knip ignoreWorkspaces, release.js pkg path, renovate/gitignore globs, ci.yml working-directory + admin coverage artifact flow
- asset-delivery needed no change: apps/ember-admin sits at the same depth as ghost/admin, so its ../../apps/* lookups resolve identically
- verified: pnpm install, @tryghost/admin:build (populates core/built/admin), ghost-admin:lint, actionlint ci.yml
- part of pulling non-core code out of the ghost/ folder so its contents can be reorganised; the Ember admin is a frontend app and belongs alongside the other apps/* - nx/npm package name stays ghost-admin, so every nx project reference (@tryghost/admin build chain, ci.yml, root scripts, vscode tasks) keeps working untouched - fixed the paths that are genuinely directory-relative rather than project-name-based: apps/admin vite ember-assets sibling path, the ember-admin nx dev cwd, knip ignoreWorkspaces, release.js pkg path, renovate/gitignore globs, ci.yml working-directory + admin coverage artifact flow - asset-delivery needed no change: apps/ember-admin sits at the same depth as ghost/admin, so its ../../apps/* lookups resolve identically - verified: pnpm install, @tryghost/admin:build (populates core/built/admin), ghost-admin:lint, actionlint ci.yml
Contributor
|
Important Review skippedToo many files! This PR contains 1049 files, which is 749 over the limit of 300. To get a review, narrow the scope: Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (316)
📒 Files selected for processing (1049)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 29s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 3m 14s | View ↗ |
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 6m 15s | View ↗ |
nx run-many -t test:unit -p @tryghost/adapter-b... |
✅ Succeeded | 6m 3s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 22s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 1s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 50s | View ↗ |
nx run-many -t lint -p @tryghost/adapter-base-r... |
✅ Succeeded | 3m 6s | View ↗ |
Additional runs (9) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-22 12:48:07 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.