Removed legacy settings behavior and editor components#29542
Merged
Conversation
no ref Centralized reusable behavior in Shade while keeping product-specific editors local ahead of removing admin-x-design-system.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (71)
WalkthroughThe change relocates color-picker, sortable-list, and sticky-footer building blocks into Shade, adds their public exports and stories, and prunes the corresponding admin-x-design-system exports and dependencies. Admin X settings gains local field components, updated editor styling, revised imports, navigation layout changes, stable sortable-list comparisons, and related tests. Accessibility labels are added to color inputs, and several UI headings and controls receive updated styling. Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)apps/admin-x-design-system/package.jsonTraceback (most recent call last): apps/admin-x-settings/package.jsonTraceback (most recent call last): apps/shade/package.jsonTraceback (most recent call last):
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 3m 1s | View ↗ |
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 8m 15s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 3m 2s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-d... |
✅ Succeeded | 5m 21s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 15s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 22s | View ↗ |
nx run @tryghost/koenig-lexical:test:acceptance |
✅ Succeeded | 2m 22s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 30s | View ↗ |
Additional runs (8) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-22 20:40:55 UTC
no ref Navigation actions now share the input control center, and duplicate benefit labels no longer leave stale rows in the live tier preview.
no ref The compact trigger now keeps the selected currency visually connected to its dropdown chevron.
no ref Benefit checks should remain centered alongside their fields at every control height.
no ref Tier pricing controls and preview headings should match the surrounding settings hierarchy without overhanging their fields.
no ref Interactive and section headings should retain the primary hierarchy while disabled controls and supporting copy remain visually secondary.
9larsons
marked this pull request as ready for review
July 22, 2026 20:41
9larsons
enabled auto-merge (squash)
July 22, 2026 20:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29542 +/- ##
==========================================
+ Coverage 74.53% 74.79% +0.25%
==========================================
Files 1609 1611 +2
Lines 141475 141678 +203
Branches 17261 17317 +56
==========================================
+ Hits 105443 105961 +518
+ Misses 34998 34644 -354
- Partials 1034 1073 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9larsons
added a commit
that referenced
this pull request
Jul 22, 2026
- main's offers table rework (#29534) fixed sorting to apply across signup and retention rows together and added acceptance coverage; ported the unified sort (name tiebreak, null dates last) and the offers-table-body testid into the native offers index dialog - main's color picker migration (#29538/#29542) renamed the hex input's accessible name to "Hex color" and the design suite now targets it; matched the native color picker field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SortableList,DragIndicator, andStickyFootercomponentsThe theme code editor is intentionally unchanged because its IDE-style presentation needs a separate design decision.
Why
This is the behaviours and editors slice of the admin-x-settings design-system removal. Reusable interaction patterns now live in Shade, while Ghost-specific runtime integrations remain local to Settings, reducing the legacy design-system surface without promoting product-specific components.
Validation