Migrated settings icons from admin-x-design-system#29547
Merged
9larsons merged 2 commits intoJul 23, 2026
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (147)
📒 Files selected for processing (45)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (35)
WalkthroughThe PR removes the shared Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/admin-x-settings/src/components/settings/membership/custom-fields/custom-field-icon.tsx (1)
1-12: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winImport the React type explicitly.
This module only uses
Reactfor the type annotation, butapps/admin-x-settings/tsconfig.jsondoes not include an ambient React namespace. Withjsx: "react-jsx",React.FCcan resolve toCannot find namespace 'React'; declare this withFCinstead.Proposed fix
+import type {FC} from 'react'; import {LucideIcon} from '`@tryghost/shade/utils`'; import type {MemberCustomField} from '`@tryghost/admin-x-framework/api/member-custom-fields`'; -const CustomFieldIcon: React.FC<{type: MemberCustomField['type']; className?: string}> = ({type, className}) => { +const CustomFieldIcon: FC<{type: MemberCustomField['type']; className?: string}> = ({type, className}) => {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/admin-x-settings/src/components/settings/membership/custom-fields/custom-field-icon.tsx` around lines 1 - 12, Update CustomFieldIcon to import the FC type explicitly from React and use FC for its component annotation instead of the ambient React.FC namespace; leave the icon mapping and rendering behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/admin-x-design-system/src/global/toast.tsx`:
- Around line 59-60: Update the toast icon wrapper in the toast component so it
no longer uses the grow utility that consumes remaining flex-row space; remove
grow or replace it with shrink-0, while preserving the existing icon rendering
and keeping the icon adjacent to children.
---
Nitpick comments:
In
`@apps/admin-x-settings/src/components/settings/membership/custom-fields/custom-field-icon.tsx`:
- Around line 1-12: Update CustomFieldIcon to import the FC type explicitly from
React and use FC for its component annotation instead of the ambient React.FC
namespace; leave the icon mapping and rendering behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1ad52f23-b3ac-41d7-b278-2b8840067b37
⛔ Files ignored due to path filters (147)
apps/admin-x-design-system/src/assets/icons/aa.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/add.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/ai-tagging-spark.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/align-center.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/align-left.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/angle-brackets.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/ap-network.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-bottom-left.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-bottom-right.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-down.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-left.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-right.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-top-left.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-top-right.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/arrow-up.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/at-sign.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/baseline-chart.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/bell.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/bills.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/block.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/book-open.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/brackets.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/card-list.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/cardview.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/check-circle.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/check.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/chevron-down.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/chevron-left.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/chevron-right.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/chevron-up.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/circle.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/close.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/column-layout.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/comment-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/comment.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/crown.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/discount.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/dotdotdot.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/download.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/duplicate.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/ellipsis.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/email-check.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/email.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/emailfield.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/error-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/export.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/finger-up.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/gift.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/globe-simple.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/hamburger.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/heart-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/heart.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/home.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/hyperlink-circle.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/import.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/info-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/info.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/integration.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/key.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/labs-flask.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/language.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/laptop.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/layer.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/layout-2-col.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/layout-headline.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/layout-module-1.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/like.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/line-dashed.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/line-dotted.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/line-solid.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/link-broken.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/listview.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/lock-locked.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/lock-unlocked.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/long-text.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/magnifying-glass.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/mail-block.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/mailplus.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/map-pin.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/megaphone.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/message-quote.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/mobile.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/modules-3.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/money-bags.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/navigation.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/palette.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/pen.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/picture.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/piggybank.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/play-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/portal.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/question-circle.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/quote.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/recepients.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/reload.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/send.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/share.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/single-user-block.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/single-user-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/sparkle.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/square.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/squircle-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/squircle.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/stripe-verified.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/substract.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/success-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/tags-block.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/tags-check.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/text-bold.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/text-regular.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/text-underline.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/textfield.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/thumbs-down.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/thumbs-up.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/time-back.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/trash.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/typography.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/unsplash-logo.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/upload.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/user-add.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/user-fill.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/user-page.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/user-pen.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/user.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/warning.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/world-clock.svgis excluded by!**/*.svgapps/admin-x-design-system/src/assets/icons/zapier-logo.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/beehiiv.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/facebook.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/firstpromoter.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/linkedin.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/mailchimp.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/medium.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/pintura.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/portal-icon-1.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/portal-icon-2.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/portal-icon-3.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/portal-icon-4.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/portal-icon-5.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/slack.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/squarespace.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/substack.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/transistor.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/twitter-x.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/unsplash.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/wordpress.svgis excluded by!**/*.svgapps/admin-x-settings/src/assets/images/brand-icons/zapier.svgis excluded by!**/*.svg
📒 Files selected for processing (63)
apps/admin-x-design-system/src/global/button.stories.tsxapps/admin-x-design-system/src/global/button.tsxapps/admin-x-design-system/src/global/chrome/desktop-chrome-header.stories.tsxapps/admin-x-design-system/src/global/icon.stories.tsxapps/admin-x-design-system/src/global/icon.tsxapps/admin-x-design-system/src/global/layout/app-menu.tsxapps/admin-x-design-system/src/global/layout/global-actions.tsxapps/admin-x-design-system/src/global/layout/page.stories.tsxapps/admin-x-design-system/src/global/layout/page.tsxapps/admin-x-design-system/src/global/layout/view-container.stories.tsxapps/admin-x-design-system/src/global/layout/view-container.tsxapps/admin-x-design-system/src/global/modal/modal.tsxapps/admin-x-design-system/src/global/modal/preview-modal.tsxapps/admin-x-design-system/src/global/sortable-list.tsxapps/admin-x-design-system/src/global/toast.stories.tsxapps/admin-x-design-system/src/global/toast.tsxapps/admin-x-design-system/src/index.tsapps/admin-x-design-system/src/settings/setting-nav-item.tsxapps/admin-x-framework/src/api/member-custom-fields.tsapps/admin-x-settings/src/components/exit-settings-button.tsxapps/admin-x-settings/src/components/icons/brand-icon.tsxapps/admin-x-settings/src/components/settings/advanced/history-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/content-api-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/first-promoter-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/pintura-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/slack-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/transistor-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/unsplash-modal.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/webhooks-table.tsxapps/admin-x-settings/src/components/settings/advanced/integrations/zapier-modal.tsxapps/admin-x-settings/src/components/settings/advanced/migration-tools/migration-tools-export.tsxapps/admin-x-settings/src/components/settings/advanced/migration-tools/migration-tools-import.tsxapps/admin-x-settings/src/components/settings/email/emails.tsxapps/admin-x-settings/src/components/settings/email/enable-newsletters.tsxapps/admin-x-settings/src/components/settings/email/mailgun.tsxapps/admin-x-settings/src/components/settings/email/newsletters/newsletter-detail-modal.tsxapps/admin-x-settings/src/components/settings/email/newsletters/newsletter-preview-content.tsxapps/admin-x-settings/src/components/settings/general/about.tsxapps/admin-x-settings/src/components/settings/general/seo-meta.tsxapps/admin-x-settings/src/components/settings/general/user-detail-modal.tsxapps/admin-x-settings/src/components/settings/growth/explore.tsxapps/admin-x-settings/src/components/settings/growth/network.tsxapps/admin-x-settings/src/components/settings/growth/offers/offer-success.tsxapps/admin-x-settings/src/components/settings/growth/offers/offers-index.tsxapps/admin-x-settings/src/components/settings/growth/recommendations/add-recommendation-modal-confirm.tsxapps/admin-x-settings/src/components/settings/growth/recommendations/recommendation-list.tsxapps/admin-x-settings/src/components/settings/membership/custom-fields.tsxapps/admin-x-settings/src/components/settings/membership/custom-fields/custom-field-icon.tsxapps/admin-x-settings/src/components/settings/membership/custom-fields/custom-field-modal.tsxapps/admin-x-settings/src/components/settings/membership/member-emails.tsxapps/admin-x-settings/src/components/settings/membership/member-emails/welcome-email-modal.tsxapps/admin-x-settings/src/components/settings/membership/portal/look-and-feel.tsxapps/admin-x-settings/src/components/settings/membership/stripe/stripe-connect-modal.tsxapps/admin-x-settings/src/components/settings/membership/tiers/tier-detail-modal.tsxapps/admin-x-settings/src/components/settings/membership/tiers/tier-detail-preview.tsxapps/admin-x-settings/src/components/settings/membership/tiers/tiers-list.tsxapps/admin-x-settings/src/components/settings/site/change-theme.tsxapps/admin-x-settings/src/components/settings/site/navigation/navigation-edit-form.tsxapps/admin-x-settings/src/components/settings/site/theme/advanced-theme-settings.tsxapps/admin-x-settings/src/components/settings/site/theme/theme-preview.tsxapps/admin-x-settings/src/components/sidebar.tsxapps/admin/src/settings/membership/custom-fields.acceptance.test.tsx
💤 Files with no reviewable changes (4)
- apps/admin/src/settings/membership/custom-fields.acceptance.test.tsx
- apps/admin-x-design-system/src/global/icon.tsx
- apps/admin-x-design-system/src/global/icon.stories.tsx
- apps/admin-x-design-system/src/index.ts
Comment on lines
59
to
60
| {toastIcon && <div className='mt-px grow'>{toastIcon}</div>} | ||
| {children} |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Keep the toast icon adjacent to its content.
At Line [59], grow makes the icon wrapper absorb remaining width in the flex row, which can push the toast message far away from the icon. Remove grow or use shrink-0.
Suggested fix
- {toastIcon && <div className='mt-px grow'>{toastIcon}</div>}
+ {toastIcon && <div className='mt-px shrink-0'>{toastIcon}</div>}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| {toastIcon && <div className='mt-px grow'>{toastIcon}</div>} | |
| {children} | |
| {toastIcon && <div className='mt-px shrink-0'>{toastIcon}</div>} | |
| {children} |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/admin-x-design-system/src/global/toast.tsx` around lines 59 - 60, Update
the toast icon wrapper in the toast component so it no longer uses the grow
utility that consumes remaining flex-row space; remove grow or replace it with
shrink-0, while preserving the existing icon rendering and keeping the icon
adjacent to children.
9larsons
force-pushed
the
migrate-settings-icons-from-admin-x-design-system
branch
from
July 23, 2026 01:21
69cf678 to
1e46667
Compare
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 7m 50s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-d... |
✅ Succeeded | 4m 21s | View ↗ |
nx run ghost-admin:test |
✅ Succeeded | 2m 55s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 23s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 2m 3s | View ↗ |
nx run-many -t lint -p @tryghost/admin-x-design... |
✅ Succeeded | 1m 48s | View ↗ |
nx run @tryghost/activitypub:test:acceptance |
✅ Succeeded | 43s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-23 01:31:32 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29547 +/- ##
==========================================
+ Coverage 74.75% 74.76% +0.01%
==========================================
Files 1611 1611
Lines 141659 141678 +19
Branches 17297 17305 +8
==========================================
+ Hits 105892 105928 +36
+ Misses 34725 34707 -18
- Partials 1042 1043 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No ref.
Migrating the icons in Settings off on
admin-x-design-systemand onto Lucide.