Removed legacy settings Form component - #29560
Merged
Merged
Conversation
no ref Settings was the only consumer, so using Shade field primitives removes duplicate layout ownership before admin-x-design-system is retired.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (30)
💤 Files with no reviewable changes (3)
WalkthroughRemoved the admin-x design-system Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
9larsons
marked this pull request as ready for review
July 23, 2026 15:27
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 6m 11s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-d... |
✅ Succeeded | 2m 7s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 23s | View ↗ |
nx run-many -t lint -p @tryghost/admin-x-design... |
✅ Succeeded | 1m 13s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 26s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | <1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-23 15:37:01 UTC
9larsons
enabled auto-merge (squash)
July 23, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Formcomponent, story, and design-system exportFieldGroup,FieldSet, andFieldLegendprimitivesWhy
Settings was the only consumer of this layout wrapper. Using Shade's existing field primitives removes duplicate ownership from
admin-x-design-systemand keeps the retirement work moving without introducing another settings-specific abstraction.Validation
pnpm --filter @tryghost/admin-x-settings lintpnpm --filter @tryghost/admin-x-settings exec tsc --noEmitpnpm --filter @tryghost/admin-x-settings test:unit— 213 tests passedpnpm --filter @tryghost/admin-x-design-system lintpnpm --filter @tryghost/admin-x-design-system buildpnpm --filter @tryghost/admin test:acceptance src/settings— 299 tests passedManual validation