Skip to content

✨ Added specific-tier option to editor preview - #29739

Merged
kevinansfield merged 1 commit into
mainfrom
ship-preview-by-tier
Aug 4, 2026
Merged

✨ Added specific-tier option to editor preview#29739
kevinansfield merged 1 commit into
mainfrom
ship-preview-by-tier

Conversation

@kevinansfield

@kevinansfield kevinansfield commented Aug 4, 2026

Copy link
Copy Markdown
Member

closes https://linear.app/ghost/issue/BER-3820/

  • when previewing a post in the editor it's now possible to select a specific tier, alongside the free/paid options
  • useful when checking paywalls and tier-specific content when full content is only available to a limited paid audience

closes https://linear.app/ghost/issue/BER-3820/

- when previewing a post in the editor it's now possible to select a specific tier in addition to the free/paid options
- useful when checking paywalls and tier-specific content when full content is only available to a limited paid audience
@kevinansfield kevinansfield changed the title ✨ Added specific tier option to editor preview ✨ Added specific-tier option to editor preview Aug 4, 2026
@nx-cloud

nx-cloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit 73f3d34

Command Status Duration Result
nx run @tryghost/admin:test:acceptance ✅ Succeeded 6m 7s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-04 08:19:03 UTC

@kevinansfield
kevinansfield enabled auto-merge (squash) August 4, 2026 07:58
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fe57aad4-5188-41b2-bc53-f2015436e2fb

📥 Commits

Reviewing files that changed from the base of the PR and between 5cb9b02 and 73f3d34.

⛔ Files ignored due to path filters (1)
  • ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap is excluded by !**/*.snap
📒 Files selected for processing (7)
  • apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx
  • apps/ember-admin/app/components/editor/modals/preview/email.js
  • apps/ember-admin/app/components/editor/publish-management.js
  • apps/ember-admin/app/services/feature.js
  • apps/ember-admin/tests/acceptance/editor/post-email-preview-test.js
  • apps/ember-admin/tests/acceptance/editor/post-preview-test.js
  • ghost/core/core/shared/labs.js
💤 Files with no reviewable changes (6)
  • apps/ember-admin/app/services/feature.js
  • ghost/core/core/shared/labs.js
  • apps/ember-admin/tests/acceptance/editor/post-preview-test.js
  • apps/ember-admin/tests/acceptance/editor/post-email-preview-test.js
  • apps/ember-admin/app/components/editor/modals/preview/email.js
  • apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx

Walkthrough

Removed the previewByTier private feature from the advanced labs list and feature-related preview logic. Email preview audience parameters now use member_status and optional member_tier. Membership tiers load without the feature flag when paid memberships are enabled. Acceptance tests no longer configure the flag or cover the legacy memberSegment path.

Possibly related PRs

Suggested reviewers: acburdine

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding specific-tier selection to editor preview.
Description check ✅ Passed The description directly explains the specific-tier preview option and its purpose for testing paywalls and tier-specific content.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship-preview-by-tier

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.41%. Comparing base (5cb9b02) to head (73f3d34).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #29739   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files        1612     1612           
  Lines      141970   141967    -3     
  Branches    17548    17548           
=======================================
  Hits       107069   107069           
+ Misses      33856    33854    -2     
+ Partials     1045     1044    -1     
Flag Coverage Δ
admin-tests 55.97% <ø> (+0.01%) ⬆️
e2e-tests 77.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kevinansfield
kevinansfield merged commit d4be2be into main Aug 4, 2026
86 of 88 checks passed
@kevinansfield
kevinansfield deleted the ship-preview-by-tier branch August 4, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant