Fixed gift redemption recipient name - #30288
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Pro Run ID: 📒 Files selected for processing (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📜 Recent review details⏰ Context from checks skipped due to timeout. (10)
🧰 Additional context used📓 Path-based instructions (6)These are independent public UMD/CDN surfaces, not embedded Shade apps. Review⚙️ CodeRabbit configuration file Files:
Review whether tests prove changed behaviour, meaningful error/edge paths, and⚙️ CodeRabbit configuration file Files:
New source files must be TypeScript: flag new JS files as a required change⚙️ CodeRabbit configuration file Files:
Prioritise concrete correctness, security, data-integrity, compatibility,⚙️ CodeRabbit configuration file Files:
New files are TypeScript: Fail if the PR adds a new .js/.jsx/.cjs/.mjs source file, unless it is: a DB📄 CodeRabbit inference engine (Custom checks) Files:
Always use `pnpm`, never npm or Yarn.📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (2)
WalkthroughThe beta gift redemption page now initializes and resets the recipient name from Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change keeps personalized gifts addressed to their stored recipient while retaining the signed-in member name as a fallback. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
Full details: Type-Safe BoundariesExplanation The changed precedence uses Resolution Validate the gift redemption response at the HTTP API boundary before placing it in Full details: New Files Are TypescriptExplanation The PR adds no new files. The PR commit changes only two pre-existing files: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t test:unit -p @tryghost/portal |
✅ Succeeded | 1m 18s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 15s | View ↗ |
nx run-many -t lint -p @tryghost/portal,ghost-m... |
✅ Succeeded | 7s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 2s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 4s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-26 08:17:59 UTC
weylandswart
left a comment
weylandswart
left a comment
There was a problem hiding this comment.
Tested locally, working as expected.
no issue Gift links can be opened by a signed-in buyer, but the card should remain addressed to the recipient chosen during purchase. - Preferred the stored recipient name over the signed-in member name - Covered signed-in viewers with a focused Portal regression test
2a4c7e3 to
a44d2f4
Compare
2 participants
no issue
Gift redemption should keep a personalized gift addressed to its intended recipient, even when the buyer or another member opens the link while signed in.