Removed unused options from labs Handlebars helper - #30323
Conversation
no ref This change should have no user impact. Four options were never used: `errorMessage`, `errorContext`, `errorHelp`, and `async`. We can remove them and simplify the function a bit.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 22s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 3m 30s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 3m 3s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 53s | View ↗ |
nx run-many -t test:unit -p ghost |
✅ Succeeded | 33s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 21s | View ↗ |
nx run-many -t lint -p ghost,ghost-monorepo |
✅ Succeeded | 21s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 3s | View ↗ |
nx run @tryghost/admin:build |
✅ Succeeded | 6s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-26 14:47:12 UTC
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: QUIET Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (12)
🧰 Additional context used📓 Path-based instructions (4)New source files must be TypeScript: flag new JS files as a required change⚙️ CodeRabbit configuration file Files:
Prioritise concrete correctness, security, data-integrity, compatibility,⚙️ CodeRabbit configuration file Files:
New files are TypeScript: Fail if the PR adds a new .js/.jsx/.cjs/.mjs source file, unless it is: a DB📄 CodeRabbit inference engine (Custom checks) Files:
Always use `pnpm`, never npm or Yarn.📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (1)
WalkthroughThe Suggested reviewers: Merge Risk: ⚪ Minimal · up to This is a localized cleanup that removes unused options from the labs helper and is not expected to change user-facing behavior; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
Full details: Type-Safe BoundariesExplanation PASS. The commit changes only Full details: New Files Are TypescriptExplanation The PR changes only ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30323 +/- ##
==========================================
+ Coverage 75.64% 75.67% +0.03%
==========================================
Files 1650 1650
Lines 156785 156777 -8
Branches 19055 19066 +11
==========================================
+ Hits 118596 118643 +47
+ Misses 37210 37125 -85
- Partials 979 1009 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

no ref
This change should have no user impact.
Four options were never used:
errorMessage,errorContext,errorHelp, andasync. We can remove them and simplify the function a bit.