Skip to content

Removed SQLite jobs from CI - #30349

Merged
EvanHahn merged 1 commit into
mainfrom
remove-sqlite-from-ci
Aug 27, 2026
Merged

Removed SQLite jobs from CI#30349
EvanHahn merged 1 commit into
mainfrom
remove-sqlite-from-ci

Conversation

@EvanHahn

Copy link
Copy Markdown
Contributor

no ref

I recommend reviewing this with whitespace changes disabled.

This CI-only change should have no user impact.

Ghost has not supported SQLite in production since 5.0, released in 2022. It's partly supported in development, but because we plan to drop it, let's remove the CI jobs.

no ref

_I recommend reviewing this with whitespace changes disabled._

This CI-only change should have no user impact.

Ghost has not supported SQLite in production [since 5.0][0], released in
2022. It's sorta supported in development, but because we plan to drop
it, let's remove the CI jobs.

[0]: https://ghost.org/changelog/5/
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: f4886670-1556-4ad8-8135-5deab5027737

📥 Commits

Reviewing files that changed from the base of the PR and between afeac50 and ca54503.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (22)
  • GitHub Check: Tinybird required tests passed or skipped
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/activitypub)
  • GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/comments-ui)
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/kg-unsplash-selector)
  • GitHub Check: Build E2E Public App Assets
  • GitHub Check: Build Admin
  • GitHub Check: Stripe fixture checks
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/koenig-lexical)
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/signup-form)
  • GitHub Check: Check migration integrity
  • GitHub Check: App Playwright Acceptance Tests (@tryghost/admin)
  • GitHub Check: Check app version bump
  • GitHub Check: Build Docker Images
  • GitHub Check: Lint
  • GitHub Check: Admin tests - Chrome
  • GitHub Check: Legacy tests (Node 22.23.1, mysql8)
  • GitHub Check: Unit tests (Node 22.23.1)
  • GitHub Check: i18n
  • GitHub Check: Lint packages
  • GitHub Check: Lint docs
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-04-10T20:46:43.335Z
Learnt from: 9larsons
Repo: TryGhost/Ghost PR: 27339
File: .github/workflows/ci.yml:175-176
Timestamp: 2026-04-10T20:46:43.335Z
Learning: For this repo’s GitHub Actions CI workflows, the dependency installation step should use a direct `pnpm install --frozen-lockfile` and avoid reintroducing/remodeling custom `.github/scripts/install-deps.sh` retry/backoff logic. The workflow is intentionally designed to rely on GitHub Actions’ native retry/retry-adjacent behavior for CI reliability, so reviewers should not flag the absence of the prior custom 4-attempt backoff loop as a regression unless a new, concrete CI failure mode is documented and handled with an equivalent automated safeguard.

Applied to files:

  • .github/workflows/ci.yml
🪛 zizmor (1.29.0)
.github/workflows/ci.yml

[warning] 803-803: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false

(artipacked)


[error] 805-805: runtime artifacts potentially vulnerable to a cache poisoning attack (cache-poisoning): this step

(cache-poisoning)

🔇 Additional comments (1)
.github/workflows/ci.yml (1)

773-773: LGTM!

Also applies to: 797-813, 820-826, 873-873, 893-893, 905-922, 924-928


Walkthrough

The CI workflow removes MySQL and SQLite test matrices from the acceptance and legacy test jobs. Both jobs now run fixed MySQL 8.0 configurations with NODE_ENV=testing-mysql. They use setup-provided Node versions and unconditional frozen-lockfile installs. Acceptance tests use setup-provided coverage settings, and coverage artifact uploads depend only on coverage being enabled.

Suggested reviewers: acburdine, 9larsons, erisds

Merge Risk: ⚪ Minimal · up to ca545

This removes SQLite jobs from CI without changing production behavior, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: removing SQLite jobs from CI.
Description check ✅ Passed The description directly explains the removal of SQLite CI jobs, the production support context, and the expected lack of user impact.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed PASS. The committed diff changes only .github/workflows/ci.yml (14 additions, 67 deletions). It removes CI matrix entries and changes workflow environment/configuration values; it does not change ap…
New Files Are Typescript ✅ Passed PASS: The pull request changes only the pre-existing .github/workflows/ci.yml file. The commit diff reports one modified path and no added files. Therefore, it does not add a .js, .jsx, .cjs, …
Full details: Type-Safe Boundaries

Explanation

PASS. The committed diff changes only .github/workflows/ci.yml (14 additions, 67 deletions). It removes CI matrix entries and changes workflow environment/configuration values; it does not change application or script code. The custom check explicitly says never fail for config files, and the diff introduces no TypeScript boundary handling or typing bypass.

Full details: New Files Are Typescript

Explanation

PASS: The pull request changes only the pre-existing .github/workflows/ci.yml file. The commit diff reports one modified path and no added files. Therefore, it does not add a .js, .jsx, .cjs, or .mjs source file.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-sqlite-from-ci

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 27, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit ca54503

Command Status Duration Result
nx run @tryghost/admin:test:acceptance ✅ Succeeded 7m 53s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-27 16:03:30 UTC

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.85%. Comparing base (1978999) to head (ca54503).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30349      +/-   ##
==========================================
- Coverage   75.91%   75.85%   -0.06%     
==========================================
  Files        1671     1670       -1     
  Lines      159292   159455     +163     
  Branches    19361    19455      +94     
==========================================
+ Hits       120919   120957      +38     
- Misses      37361    37514     +153     
+ Partials     1012      984      -28     
Flag Coverage Δ
e2e-tests 77.51% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn
EvanHahn merged commit 3d15e73 into main Aug 27, 2026
102 of 104 checks passed
@EvanHahn
EvanHahn deleted the remove-sqlite-from-ci branch August 27, 2026 16:57
9larsons added a commit that referenced this pull request Aug 31, 2026
no ref

Follow-up to #30349, which removed the SQLite acceptance and legacy jobs
from CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant