Removed unused Mailgun error handler callback

[EvanHahn]

no ref

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit 7b04591

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	4m 53s	View ↗
nx run ghost:test:legacy	✅ Succeeded	2m 48s	View ↗
nx run ghost-monorepo:lint:boundaries	✅ Succeeded	22s	View ↗
nx run-many -t test:unit -p ghost	✅ Succeeded	34s	View ↗
nx run-many -t lint -p ghost,ghost-monorepo	✅ Succeeded	21s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	8s	View ↗
nx run-many --target=build --projects=tag:publi...	✅ Succeeded	<1s	View ↗
nx run @tryghost/e2e:test:fixtures	✅ Succeeded	1s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-28 14:23:32 UTC

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: e42370f1-163a-41a5-b393-476b107f5312

📥 Commits

Reviewing files that changed from the base of the PR and between 21e5c1e and 7b04591.

📒 Files selected for processing (3)

• ghost/core/core/server/services/email-service/email-service-wrapper.js
• ghost/core/core/server/services/email-service/mailgun-email-provider.js
• ghost/core/test/unit/server/services/email-service/mailgun-email-provider.test.js

💤 Files with no reviewable changes (2)

• ghost/core/core/server/services/email-service/email-service-wrapper.js
• ghost/core/test/unit/server/services/email-service/mailgun-email-provider.test.js

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (10)

• GitHub Check: Stripe fixture checks
• GitHub Check: Build Docker Images
• GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
• GitHub Check: Legacy tests (Node 22.23.1, mysql8)
• GitHub Check: Build Admin
• GitHub Check: Unit tests (Node 22.23.1)
• GitHub Check: Build E2E Public App Assets
• GitHub Check: Check app version bump
• GitHub Check: Lint
• GitHub Check: Analyze (javascript-typescript)

🧰 Additional context used

📓 Path-based instructions (6)

Review new or changed service boundaries for explicit dependency ownership,

⚙️ CodeRabbit configuration file

Files:

• ghost/core/core/server/services/email-service/mailgun-email-provider.js

New source files must be TypeScript: flag new JS files as a required change

⚙️ CodeRabbit configuration file

Files:

• ghost/core/core/server/services/email-service/mailgun-email-provider.js

Prioritise concrete correctness, security, data-integrity, compatibility,

⚙️ CodeRabbit configuration file

Files:

• ghost/core/core/server/services/email-service/mailgun-email-provider.js

Boot owns service initialization; do not

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• ghost/core/core/server/services/email-service/mailgun-email-provider.js

New files are TypeScript: Fail if the PR adds a new .js/.jsx/.cjs/.mjs source file, unless it is: a DB

📄 CodeRabbit inference engine (Custom checks)

Files:

• ghost/core/core/server/services/email-service/mailgun-email-provider.js

Always use `pnpm`, never npm or Yarn.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

• ghost/core/core/server/services/email-service/mailgun-email-provider.js

🔇 Additional comments (1)

ghost/core/core/server/services/email-service/mailgun-email-provider.js (1)

44-46: LGTM!

---

Walkthrough

The email service removes the unused error handler from EmailServiceWrapper and MailgunEmailProvider. The provider constructor now accepts only mailgunClient and config. Unit tests update all provider instantiations to match the revised constructor. Mailgun message construction, sending, recipient substitution, error wrapping, and test assertions remain unchanged.

Suggested reviewers: 9larsons

Merge Risk: ⚪ Minimal · up to 7b045

This localized cleanup removes an unused Mailgun error-handler callback and related test expectations; no actionable merge-blocking risk remains after normal checks.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description, "no ref," is too vague to confirm that it describes the changeset.	Add a brief description stating that the unused Mailgun error handler callback and its related dependency wiring were removed.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: removal of the unused Mailgun error handler callback.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries	✅ Passed	PASS — The commit only removes the Mailgun errorHandler dependency and updates constructor call sites. The only added line is constructor({mailgunClient, config}); it adds no boundary-data consump…
New Files Are Typescript	✅ Passed	PASS. The pull request adds no files. The diff against origin/main contains only modifications to three pre-existing .js files, so the explicit failure condition is not met.

Full details: Type-Safe Boundaries

Explanation

PASS — The commit only removes the Mailgun errorHandler dependency and updates constructor call sites. The only added line is constructor({mailgunClient, config}); it adds no boundary-data consumption, Zod/schema duplication, or type-bypass marker. Existing Mailgun response and config handling is unchanged, and the test edits are exempt.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-unused-mailgun-errorhandler

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.03%. Comparing base (21e5c1e) to head (7b04591).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30359      +/-   ##
==========================================
+ Coverage   75.99%   76.03%   +0.03%     
==========================================
  Files        1676     1676              
  Lines      159975   159964      -11     
  Branches    19574    19581       +7     
==========================================
+ Hits       121572   121623      +51     
+ Misses      37382    37351      -31     
+ Partials     1021      990      -31     

Flag	Coverage Δ
e2e-tests	77.69% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.