Removed unused debug code from batch sending service

[EvanHahn]

no ref

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit f865171

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	5m	View ↗
nx run ghost:test:legacy	✅ Succeeded	3m 7s	View ↗
nx run-many -t test:unit -p ghost	✅ Succeeded	24s	View ↗
nx run ghost-monorepo:lint:boundaries	✅ Succeeded	18s	View ↗
nx run-many -t lint -p ghost,ghost-monorepo	✅ Succeeded	18s	View ↗
nx run-many --target=build --projects=tag:publi...	✅ Succeeded	<1s	View ↗
nx run @tryghost/e2e:test:fixtures	✅ Succeeded	<1s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	3s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-28 14:27:16 UTC

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: 4537c26b-28db-4036-9e68-070561835460

📥 Commits

Reviewing files that changed from the base of the PR and between 21e5c1e and f865171.

📒 Files selected for processing (2)

• ghost/core/core/server/services/email-service/batch-sending-service.js
• ghost/core/core/server/services/email-service/email-service-wrapper.js

💤 Files with no reviewable changes (2)

• ghost/core/core/server/services/email-service/email-service-wrapper.js
• ghost/core/core/server/services/email-service/batch-sending-service.js

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (12)

• GitHub Check: Build Admin
• GitHub Check: Stripe fixture checks
• GitHub Check: Unit tests (Node 22.23.1)
• GitHub Check: i18n
• GitHub Check: Build E2E Public App Assets
• GitHub Check: Check migration integrity
• GitHub Check: Legacy tests (Node 22.23.1, mysql8)
• GitHub Check: Build Docker Images
• GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
• GitHub Check: Lint
• GitHub Check: Check app version bump
• GitHub Check: Analyze (javascript-typescript)

---

Walkthrough

The pull request removes the unused debugStorageFilePath dependency from BatchSendingService. It deletes the private field, constructor documentation, destructured parameter, and state assignment. The email service wrapper no longer passes debugStorageFilePath when it constructs BatchSendingService.

Merge Risk: ⚪ Minimal · up to f8651

This localized cleanup removes unused debug code without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description states only "no ref". It does not meaningfully describe the removal of unused debug code.	Add a brief description of the removed debugStorageFilePath dependency and the affected batch sending service.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately identifies the removal of unused debug code from the batch sending service. It is concise and specific.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries	✅ Passed	PASS. The PR only removes the unused debugStorageFilePath field, JSDoc parameter, constructor destructuring, assignment, and wrapper option. The parent revision shows these were the only references,…
New Files Are Typescript	✅ Passed	PASS. The pull request adds no files. Both changed paths are pre-existing .js files, and the diff status is M for each. The check explicitly excludes modifications to pre-existing JavaScript files…

Full details: Type-Safe Boundaries

Explanation

PASS. The PR only removes the unused debugStorageFilePath field, JSDoc parameter, constructor destructuring, assignment, and wrapper option. The parent revision shows these were the only references, and the PR adds no code. It does not introduce unvalidated boundary data consumption or typing bypasses.

Full details: New Files Are Typescript

Explanation

PASS. The pull request adds no files. Both changed paths are pre-existing .js files, and the diff status is M for each. The check explicitly excludes modifications to pre-existing JavaScript files from failure.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-unused-debug-storage-path

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.99%. Comparing base (21e5c1e) to head (f865171).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #30360   +/-   ##
=======================================
  Coverage   75.99%   75.99%           
=======================================
  Files        1676     1676           
  Lines      159975   159970    -5     
  Branches    19574    19571    -3     
=======================================
- Hits       121572   121569    -3     
- Misses      37382    37411   +29     
+ Partials     1021      990   -31     

Flag	Coverage Δ
e2e-tests	77.65% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.