Skip to content

Removed unused deps from member API event repository - #30361

Merged
EvanHahn merged 1 commit into
mainfrom
remove-unused-member-api-event-dependencies
Aug 28, 2026
Merged

Removed unused deps from member API event repository#30361
EvanHahn merged 1 commit into
mainfrom
remove-unused-member-api-event-dependencies

Conversation

@EvanHahn

Copy link
Copy Markdown
Contributor

no ref

@nx-cloud

nx-cloud Bot commented Aug 28, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit c2affbf

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 3m 24s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 9s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 19s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 24s View ↗
nx run @tryghost/admin:build ✅ Succeeded 7s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 21s View ↗
nx run @tryghost/e2e:test:fixtures ✅ Succeeded 1s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-28 14:27:16 UTC

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: 9740c843-0e70-433a-9cd3-acb0b129daae

📥 Commits

Reviewing files that changed from the base of the PR and between 21e5c1e and c2affbf.

📒 Files selected for processing (2)
  • ghost/core/core/server/services/members/members-api/members-api.js
  • ghost/core/core/server/services/members/members-api/repositories/event-repository.js
💤 Files with no reviewable changes (2)
  • ghost/core/core/server/services/members/members-api/members-api.js
  • ghost/core/core/server/services/members/members-api/repositories/event-repository.js

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (12)
  • GitHub Check: Build Docker Images
  • GitHub Check: Check migration integrity
  • GitHub Check: Stripe fixture checks
  • GitHub Check: Legacy tests (Node 22.23.1, mysql8)
  • GitHub Check: Unit tests (Node 22.23.1)
  • GitHub Check: Acceptance tests (Node 22.23.1, mysql8)
  • GitHub Check: Build E2E Public App Assets
  • GitHub Check: Check app version bump
  • GitHub Check: Build Admin
  • GitHub Check: i18n
  • GitHub Check: Lint
  • GitHub Check: Analyze (javascript-typescript)

Walkthrough

The Members API no longer destructures SubscriptionCreatedEvent from its models. It also stops passing this dependency to MemberRepository and EventRepository. EventRepository no longer accepts or stores SubscriptionCreatedEvent and labsService.

Merge Risk: ⚪ Minimal · up to c2aff

This PR removes unused dependencies from the member API event repository and has no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is "no ref" and does not provide meaningful information about the dependency removal. Replace "no ref" with a brief summary of the removed unused dependencies from the member API event repository.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: removal of unused dependencies from the member API event repository.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries ✅ Passed PASS. The pull request changes only two existing JavaScript files and removes six unused dependency declarations or assignments. The diff introduces no boundary-data consumption, Zod or other schema c…
New Files Are Typescript ✅ Passed The PR does not add any source files. The diff contains only modifications to two pre-existing .js files, and both paths exist in origin/main. The check excludes modifications to pre-existing Java…
Full details: Type-Safe Boundaries

Explanation

PASS. The pull request changes only two existing JavaScript files and removes six unused dependency declarations or assignments. The diff introduces no boundary-data consumption, Zod or other schema changes, any, unchecked casts, @ts-nocheck, @ts-ignore, or duplicated types. The remaining SubscriptionCreatedEvent use is in the unchanged MemberRepository, not in the changed EventRepository logic.

Full details: New Files Are Typescript

Explanation

The PR does not add any source files. The diff contains only modifications to two pre-existing .js files, and both paths exist in origin/main. The check excludes modifications to pre-existing JavaScript files from failure.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-unused-member-api-event-dependencies

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.99%. Comparing base (21e5c1e) to head (c2affbf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #30361      +/-   ##
==========================================
- Coverage   75.99%   75.99%   -0.01%     
==========================================
  Files        1676     1676              
  Lines      159975   159969       -6     
  Branches    19574    19575       +1     
==========================================
- Hits       121572   121565       -7     
- Misses      37382    37414      +32     
+ Partials     1021      990      -31     
Flag Coverage Δ
e2e-tests 77.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn
EvanHahn merged commit ceb4d78 into main Aug 28, 2026
53 checks passed
@EvanHahn
EvanHahn deleted the remove-unused-member-api-event-dependencies branch August 28, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant