Removed impossible code path from support email address code

[EvanHahn]

no ref

This change should have no user impact.

The previous conditional meant that this line did nothing. Let's remove it.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: d1bf83be-846e-4c7e-a5f3-c0b769a68059

📥 Commits

Reviewing files that changed from the base of the PR and between 21e5c1e and f87c5d3.

📒 Files selected for processing (1)

• ghost/core/core/server/services/settings-helpers/settings-helpers.js

💤 Files with no reviewable changes (1)

• ghost/core/core/server/services/settings-helpers/settings-helpers.js

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (3)

• GitHub Check: Setup
• GitHub Check: Detect Tinybird changes
• GitHub Check: Analyze (javascript-typescript)

---

Walkthrough

getMembersSupportAddress() no longer converts an empty support-address setting to noreply. Missing or empty settings now use the formatted default email.

Merge Risk: ⚪ Minimal · up to f87c5

This is a narrowly scoped cleanup that removes an impossible code path and is not expected to change user behavior; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the removal of an ineffective code path in the support email address code.
Description check	✅ Passed	The description explains that an ineffective conditional was removed and states the expected lack of user impact.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries	✅ Passed	PASS — The PR changes only an existing JavaScript helper and deletes two lines. The removed assignment was after if (!supportAddress) return, so it could not process boundary data or add a typing by…
New Files Are Typescript	✅ Passed	PASS. The pull request modifies one pre-existing file, ghost/core/core/server/services/settings-helpers/settings-helpers.js. The parent revision already contains this file. The patch removes two lin…

Full details: Type-Safe Boundaries

Explanation

PASS — The PR changes only an existing JavaScript helper and deletes two lines. The removed assignment was after if (!supportAddress) return, so it could not process boundary data or add a typing bypass. The diff introduces no Zod/schema issue, any, unchecked as, @ts-nocheck, or @ts-ignore.

Full details: New Files Are Typescript

Explanation

PASS. The pull request modifies one pre-existing file, ghost/core/core/server/services/settings-helpers/settings-helpers.js. The parent revision already contains this file. The patch removes two lines and adds no files. The check does not fail for modifying pre-existing JavaScript files.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch impossible-path-from-getMembersSupportAddress

---

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit f87c5d3

Command	Status	Duration	Result
nx run ghost:test:ci:integration	✅ Succeeded	4m 28s	View ↗
nx run ghost:test:legacy	✅ Succeeded	3m 19s	View ↗
nx run ghost-monorepo:lint:boundaries	✅ Succeeded	23s	View ↗
nx run-many -t test:unit -p ghost	✅ Succeeded	36s	View ↗
nx run-many -t lint -p ghost,ghost-monorepo	✅ Succeeded	22s	View ↗
nx run @tryghost/e2e:test:fixtures	✅ Succeeded	1s	View ↗
nx run @tryghost/admin:build	✅ Succeeded	3s	View ↗
nx run-many --target=build --projects=tag:publi...	✅ Succeeded	<1s	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-28 14:33:07 UTC

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.99%. Comparing base (21e5c1e) to head (f87c5d3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #30362      +/-   ##
==========================================
- Coverage   75.99%   75.99%   -0.01%     
==========================================
  Files        1676     1676              
  Lines      159975   159973       -2     
  Branches    19574    19569       -5     
==========================================
- Hits       121572   121570       -2     
- Misses      37382    37413      +31     
+ Partials     1021      990      -31     

Flag	Coverage Δ
e2e-tests	77.65% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.